blender
/
blender
136
406
Fork 590
Code Issues 6.2k Pull Requests 764 Projects 19 Wiki Activity

UI: Clicking the camera icon while rendering should open render window #105765

Merged
Jeroen Bakker merged 6 commits from rems64/blender:T102210-click-camera-icon into main 2023-03-21 07:53:41 +01:00
Conversation 6 Commits 6 Files Changed 1 +3 -3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 441a043b71 - Show all commits

6
source/blender/editors/interface/interface_templates.cc
View File

@ -6125,7 +6125,7 @@ void uiTemplateRunningJobs(uiLayout *layout, bContext *C)
void *owner = nullptr;
int handle_event, icon = 0;
const char *op_name = nullptr;
const char *op_desc = nullptr;
const char *op_description = nullptr;
Jeroen Bakker commented 2023-03-18 09:58:35 +01:00
Outdated
Review
Copy Link

Best to use none abbreviated names op_description.
Code is mostly written once, but read many times, code and naming should reflect this.

Best to use none abbreviated names `op_description`. Code is mostly written once, but read many times, code and naming should reflect this.
uiBlock *block = uiLayoutGetBlock(layout);
UI_block_layout_set_current(block, layout);
@ -6188,7 +6188,7 @@ void uiTemplateRunningJobs(uiLayout *layout, bContext *C)
handle_event = B_STOPRENDER;
icon = ICON_SCENE;
op_name = "RENDER_OT_view_show";
op_desc = "Show the render window";
op_description = "Show the render window";
break;
}
if (WM_jobs_test(wm, scene, WM_JOB_TYPE_COMPOSITE)) {
@ -6256,7 +6256,7 @@ void uiTemplateRunningJobs(uiLayout *layout, bContext *C)
0,
UI_UNIT_X,
UI_UNIT_Y,
TIP_(op_desc));
TIP_(op_description));
}
/* job name and icon if not previously set */