blender
/
blender
137
415
Fork 598
Code Issues 6.3k Pull Requests 768 Projects 19 Wiki Activity

Vulkan: Provide utilities to put markers and labels where needed in the GPUmodule #106098

Merged
Jeroen Bakker merged 29 commits from :vk_debug_update into main 2023-04-21 12:32:52 +02:00
Conversation 1 Commits 29 Files Changed 8 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 60f47e80dc - Show all commits

4
source/blender/gpu/vulkan/vk_debug.cc
View File

@ -110,10 +110,10 @@ static void vulkan_dynamic_debug_functions(VKContext *context, PFN_vkGetInstance
}
}
bool init_callbacks(VKContext *contex, PFN_vkGetInstanceProcAddr instload)
bool init_callbacks(VKContext *context, PFN_vkGetInstanceProcAddr instload)
{
if (instload) {
vulkan_dynamic_debug_functions(contex, instload);
vulkan_dynamic_debug_functions(context, instload);
return true;
};
return false;
vnapdv marked this conversation as resolved
Jeroen Bakker commented 2023-04-03 13:40:40 +02:00
Review
Copy Link

use context when referring to VKContext (be consistent with other areas of the code-base)

When referring to instances of the Vulkan API it is used. Eg VkCommandBuffer parameters should be named vk_command_buffer VKCommandBuffer (internal class) should be referred to as command_buffer.

Abbreviations like q should not be used, just call them what they are queue.

etc

use `context` when referring to `VKContext` (be consistent with other areas of the code-base) When referring to instances of the Vulkan API it is used. Eg VkCommandBuffer parameters should be named `vk_command_buffer` VKCommandBuffer (internal class) should be referred to as `command_buffer`. Abbreviations like `q` should not be used, just call them what they are `queue`. etc