blender
/
blender
137
415
Fork 598
Code Issues 6.3k Pull Requests 765 Projects 19 Wiki Activity

UI: Gray out Scene Auto-Masking option if equivalent Brush option is used #102971 #106126

Open
Henry-Chang wants to merge 11 commits from Henry-Chang/blender:gray-out-automasking into main
pull from: Henry-Chang/blender:gray-out-automasking
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 20 Commits 11 Files Changed 14 +13 -4
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit f69302fdd7 - Show all commits

17
source/blender/editors/interface/interface_region_tooltip.cc
View File

@ -897,16 +897,25 @@ static uiTooltipData *ui_tooltip_data_from_button_or_extra_icon(bContext *C,
MEM_freeN(str);
}
if (but->flag & UI_BUT_INACTIVE) {
const char *inactive_msg = nullptr;
Julian Eisel commented 2023-05-15 11:26:05 +02:00
Review
Copy Link

Can be shortened:

if ((but->flag & (UI_BUT_DISABLED | UI_BUT_INACTIVE)) || extra_icon) {
  ...
}
Can be shortened: ```C if ((but->flag & (UI_BUT_DISABLED | UI_BUT_INACTIVE)) || extra_icon) { ... } ```
Henry-Chang commented 2023-05-15 14:26:41 +02:00
Review
Copy Link

Understood, would update.

Understood, would update.
if ((rna_struct.strinfo && strcmp(rna_struct.strinfo, "SCULPT_OT_mask_from_cavity") == 0) || (rna_prop.strinfo && strstr(rna_prop.strinfo, "automasking"))) {
inactive_msg = "The active brush already has the same auto-masking enabled.";
}
if (inactive_msg && inactive_msg[0]) {
uiTooltipField *field = text_field_add(
data, uiTooltipFormat::Style::Normal, uiTooltipFormat::ColorID::Alert);
field->text = BLI_sprintfN(TIP_("Disabled: %s"), inactive_msg);
}
}
/* Button is disabled, we may be able to tell user why. */
if ((but->flag & UI_BUT_DISABLED) || extra_icon) {
const char *disabled_msg = nullptr;
bool disabled_msg_free = false;
/* If operator poll check failed, it can give pretty precise info why. */
if (strcmp(rna_struct.strinfo, "SCULPT_OT_mask_from_cavity") == 0 || strstr(rna_prop.strinfo, "automasking")) {
disabled_msg = "The active brush already has the same auto-masking enabled.";
}
else if (optype) {
if (optype) {
const wmOperatorCallContext opcontext = extra_icon ? extra_icon->optype_params->opcontext :
but->opcontext;
wmOperatorCallParams call_params{};