blender
/
blender
136
404
Fork 586
Code Issues 6.2k Pull Requests 762 Projects 19 Wiki Activity

Animation: Armature symmetrize ebones refactor #106487

Manually merged
Sybren A. Stüvel merged 5 commits from cgtinker/blender:symmetrize-refactoring into main 2023-05-15 11:09:36 +02:00
Conversation 3 Commits 5 Files Changed 1 +1 -3
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 4cd6bf07d0 - Show all commits

4
source/blender/editors/armature/armature_add.c
View File

@ -1189,9 +1189,7 @@ static int armature_symmetrize_exec(bContext *C, wmOperator *op)
}
/* Set temp pointer to mirrored ebones */
if (ebone) {
ebone_iter->temp.ebone = ebone;
}
ebone_iter->temp.ebone = ebone;
Sybren A. Stüvel commented 2023-04-11 16:00:48 +02:00
Outdated
Review
Copy Link

When you're here in the code, ebone is guaranteed to be non-NULL.
And even if it were to be NULL, setting ebone_iter->temp.ebone = NULL in that case also wouldn't hurt.

When you're here in the code, `ebone` is guaranteed to be non-`NULL`. And even if it were to be `NULL`, setting `ebone_iter->temp.ebone = NULL` in that case also wouldn't hurt.
👍 1
Denys Hsu commented 2023-04-19 17:30:12 +02:00
Outdated
Review
Copy Link

Right, I've overlooked that, thanks.

Right, I've overlooked that, thanks.
}
/* Find the selected bones and duplicate them as needed, with mirrored name. */