blender
/
blender
136
404
Fork 586
Code Issues 6.2k Pull Requests 758 Projects 19 Wiki Activity

Animation: blend to infinity slider #106517

Closed
AresDeveaux wants to merge 15 commits from AresDeveaux/blender:blend_to_infinity_slider into main
pull from: AresDeveaux/blender:blend_to_infinity_slider
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 12 Commits 15 Files Changed 6 +10 -22
2 changed files with 10 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit f231c18d95 - Show all commits

27
source/blender/editors/animation/keyframes_general.c
View File

@ -496,36 +496,28 @@ void blend_to_infinity_fcurve_segment(FCurve *fcu, FCurveSegment *segment, const
const BezTriple *left_key = fcurve_segment_start_get(fcu, segment->start_index);
const BezTriple *right_key = fcurve_segment_end_get(fcu, segment->start_index + segment->length);
/* The factor goes from 0 to 1, but for this tool it needs to go from 0 to 1 on each side of the
* slider. */
const float bidirectional_factor = fabs(factor * 2 - 1);
BezTriple beyond_key;
const BezTriple *reference_key;
Christoph Lendenfeld commented 2023-04-09 20:00:38 +02:00
Outdated
Review
Copy Link

I think instead of splitting the vector into its two components it would be better to keep it as a vector and use the functions in math_vector_inline.c

This will potentially simplify your code quite a lot.

I think instead of splitting the vector into its two components it would be better to keep it as a vector and use the functions in `math_vector_inline.c` This will potentially simplify your code quite a lot.
/* This delta values are used to get the relationship between the bookend keys and the
* reference keys beyong those. */
if (factor >= 0.5) {
if (factor >= 0) {
/* Stop the function if there is no key beyond the the right neighboring one. */
if (segment->start_index + segment->length > fcu->totvert - 1) {
if (segment->start_index + segment->length >= fcu->totvert - 1) {
return;
}
reference_key = right_key;
beyond_key = fcu->bezt[segment->start_index + segment->length + 1];
}
else {
/* Stop the function if there is no key beyond the left neighboring one. */
if (segment->start_index == 1) {
if (segment->start_index <= 1) {
return;
Christoph Lendenfeld commented 2023-04-15 19:21:33 +02:00
Outdated
Review
Copy Link

this can also be clearer.
segment->start_index + segment->length > fcu->totvert

this can also be clearer. `segment->start_index + segment->length > fcu->totvert`
AresDeveaux commented 2023-04-18 03:48:32 +02:00
Outdated
Review
Copy Link

I tried this change as well as the next one and it doesn't work as it should. Remember, we need 2 keys before and after the segment, the way you suggest just account for one. If I don't prevent not having 2 keys at each side of the segment the tool goes crazy.

I tried this change as well as the next one and it doesn't work as it should. Remember, we need 2 keys before and after the segment, the way you suggest just account for one. If I don't prevent not having 2 keys at each side of the segment the tool goes crazy.
}
reference_key = left_key;
beyond_key = fcu->bezt[segment->start_index - 2];
}
Christoph Lendenfeld commented 2023-04-09 20:03:18 +02:00
Outdated
Review
Copy Link

I don't think you need this. At least I can't see it being used other than the check for 0.0f

If it is required that there is more than 1 key selected, update the comment because there is no potential divide by 0

I don't think you need this. At least I can't see it being used other than the check for 0.0f If it is required that there is more than 1 key selected, update the comment because there is no potential divide by 0
/* This delta values are used to get the relationship between the bookend keys and the
* reference keys beyong those. */
const float y_delta = beyond_key.vec[1][1] - reference_key->vec[1][1];
const float x_delta = beyond_key.vec[1][0] - reference_key->vec[1][0];
Christoph Lendenfeld commented 2023-04-15 19:18:45 +02:00
Outdated
Review
Copy Link

This would be clearer if you checked explicitly to 0
segment->start_index == 0

the start index will never be smaller than 0

This would be clearer if you checked explicitly to 0 `segment->start_index == 0` the start index will never be smaller than 0
Christoph Lendenfeld commented 2023-04-20 11:07:51 +02:00
Outdated
Review
Copy Link

I am glad you didn't listen to me here, because I just realized what I suggested is wrong 🤦

I am glad you didn't listen to me here, because I just realized what I suggested is wrong 🤦
@ -534,13 +526,6 @@ void blend_to_infinity_fcurve_segment(FCurve *fcu, FCurveSegment *segment, const
return;
Christoph Lendenfeld commented 2023-04-21 10:28:34 +02:00
Outdated
Review
Copy Link

shouldn't this return false?
also now that I think about it, I am not sure x_delta can ever be 0. It would only be 0 if the beyond key and the reference key are the same, which they cannot be since you are getting different indices.
Hm ok writing this now, you can have the curve in a state where two keys are at the same point in time. Shouldn't happen, but could...

Anyway, the function should return true if it ran and false if it didn't. Since you are exiting early here, I think it should return false.

shouldn't this return false? also now that I think about it, I am not sure x_delta can ever be 0. It would only be 0 if the beyond key and the reference key are the same, which they cannot be since you are getting different indices. Hm ok writing this now, you can have the curve in a state where two keys are at the same point in time. Shouldn't happen, but could... Anyway, the function should return true if it ran and false if it didn't. Since you are exiting early here, I think it should return false.
}
if (factor >= 0.5) {
reference_key = right_key;
}
else {
reference_key = left_key;
}
for (int i = segment->start_index; i < segment->start_index + segment->length; i++) {
/* These new deltas are used to determine the relationship between the current key and the
Christoph Lendenfeld commented 2023-04-15 19:16:05 +02:00
Outdated
Review
Copy Link

since this is now outside of the if else, you can to
const float y_delta = ...
and then remove the lines 503 and 504

since this is now outside of the if else, you can to `const float y_delta = ...` and then remove the lines 503 and 504
@ -550,7 +535,7 @@ void blend_to_infinity_fcurve_segment(FCurve *fcu, FCurveSegment *segment, const
const float delta = reference_key->vec[1][1] + new_y_delta - fcu->bezt[i].vec[1][1];
const float key_y_value = fcu->bezt[i].vec[1][1] + delta * bidirectional_factor;
const float key_y_value = fcu->bezt[i].vec[1][1] + delta * fabs(factor);
move_key(&fcu->bezt[i], key_y_value);
Christoph Lendenfeld commented 2023-04-15 19:25:23 +02:00
Outdated
Review
Copy Link

this can move into the for loop and you can then call it
const float new_x_delta = ...

this can move into the for loop and you can then call it `const float new_x_delta = ...`
}
}

5
source/blender/editors/space_graph/graph_slider_ops.c
View File

@ -1074,7 +1074,7 @@ static void blend_to_infinity_graph_keys(bAnimContext *ac, const float factor)
ListBase segments = find_fcurve_segments(fcu);
LISTBASE_FOREACH (FCurveSegment *, segment, &segments) {
if (factor >= 0.5){
if (factor >= 0){
if (segment->start_index + segment->length >= fcu->totvert - 1) {
WM_report(RPT_WARNING, "You need at least 2 keys to the right side of the selection.");
Christoph Lendenfeld commented 2023-04-15 19:22:44 +02:00
Outdated
Review
Copy Link

the conditions can also be simplified like above
you can also continue after the warning because the code cannot run anyway

the conditions can also be simplified like above you can also `continue` after the warning because the code cannot run anyway
AresDeveaux commented 2023-04-18 03:47:13 +02:00
Outdated
Review
Copy Link

your suggestion of adding continue to the condition for the warning works, but made me realize 2 things:

1.- I need to split the warning into two possibilities. One when we don't have two reference keys on the left, and another if we don't have two reference keys on the right. As it is now it locks the function even if one of the sides has all it needs (I added this)

2.- If we put continue on the condition in graph_slider_ops.c we don't need the same if statements in `keyframes_general.c' since it will never be executed. (I didn't delete them until you take a look at it)

By the way, doesn't it bother you the warning is blinking? I'm thinking it's doing that because of where I put it. I think it is refreshing as the function is called back when the slider is modified, but don't know in what function I should put it to avoid it.

your suggestion of adding continue to the condition for the warning works, but made me realize 2 things: 1.- I need to split the warning into two possibilities. One when we don't have two reference keys on the left, and another if we don't have two reference keys on the right. As it is now it locks the function even if one of the sides has all it needs (I added this) 2.- If we put continue on the condition in graph_slider_ops.c we don't need the same if statements in `keyframes_general.c' since it will never be executed. (I didn't delete them until you take a look at it) By the way, doesn't it bother you the warning is blinking? I'm thinking it's doing that because of where I put it. I think it is refreshing as the function is called back when the slider is modified, but don't know in what function I should put it to avoid it.
Christoph Lendenfeld commented 2023-04-20 11:03:22 +02:00
Outdated
Review
Copy Link

Let's have the warning outside of the for-loop so it's only displayed once per modal cycle
so make a bool all_segments_valid = true
and where the warning is now, set it to false

then after the 2 loops do a if(!all_segments_valid)

Let's have the warning outside of the for-loop so it's only displayed once per modal cycle so make a `bool all_segments_valid = true` and where the warning is now, set it to false then after the 2 loops do a `if(!all_segments_valid)`
continue;
@ -1146,6 +1146,9 @@ static int blend_to_infinity_invoke(bContext *C, wmOperator *op, const wmEvent *
gso->modal_update = blend_to_infinity_modal_update;
gso->factor_prop = RNA_struct_find_property(op->ptr, "factor");
blend_to_infinity_draw_status_header(C, gso);
ED_slider_allow_overshoot_set(gso->slider, false);
ED_slider_is_bidirectional_set(gso->slider, true);
ED_slider_factor_set(gso->slider, 0.0f);
return invoke_result;
}