blender
/
blender
133
398
Fork 579
Code Issues 6.3k Pull Requests 747 Projects 19 Wiki Activity

Initial Grease Pencil 3.0 stage #106848

Merged
Falk David merged 224 commits from filedescriptor/blender:grease-pencil-v3 into main 2023-05-30 11:14:22 +02:00
Conversation 8 Commits 224 Files Changed 94 +4
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 22527b9bbc - Show all commits

4
source/blender/blenkernel/intern/grease_pencil.cc
View File

@ -419,6 +419,10 @@ Span<int> Layer::sorted_keys() const
int Layer::drawing_index_at(int frame) const
{
Span<int> sorted_keys = this->sorted_keys();
Hans Goudey commented 2023-05-02 23:39:38 +02:00
Outdated
Review
Copy Link

Forget if we talked about this already, but without std::move in the function, there doesn't seem to be much of a point to this second override. Usually there is one for a const reference and one for an rvalue, I haven't seen a non-const reference override like this before.

Forget if we talked about this already, but without `std::move` in the function, there doesn't seem to be much of a point to this second override. Usually there is one for a const reference and one for an rvalue, I haven't seen a non-const reference override like this before.
Falk David commented 2023-05-03 11:02:06 +02:00
Outdated
Review
Copy Link

Maybe @JacquesLucke can clarify here, but I believe sine add_overwrite has an implementation with an r-value reference that does the std::move I think this is fine?

Maybe @JacquesLucke can clarify here, but I believe sine `add_overwrite` has an implementation with an r-value reference that does the `std::move` I think this is fine?
Jacques Lucke commented 2023-05-03 11:05:50 +02:00
Outdated
Review
Copy Link

I recommend just using a debugger to see if this calls the function you intend to call (the one with an rvalue reference). Haven't tried right now, but it will probably call the const reference version without std::move.

I recommend just using a debugger to see if this calls the function you intend to call (the one with an rvalue reference). Haven't tried right now, but it will probably call the const reference version without `std::move`.
👍 1
/* No keyframes, return no drawing. */
if (sorted_keys.size() == 0) {
return -1;
}
/* Before the first drawing, return no drawing. */
if (frame < sorted_keys.first()) {
Hans Goudey commented 2023-04-25 04:56:25 +02:00
Outdated
Review
Copy Link

Any reason to call clear_and_shrink here? Might as well call reinitialize if not

Any reason to call `clear_and_shrink` here? Might as well call `reinitialize` if not
return -1;