blender
/
blender
133
398
Fork 579
Code Issues 6.3k Pull Requests 747 Projects 19 Wiki Activity

Initial Grease Pencil 3.0 stage #106848

Merged
Falk David merged 224 commits from filedescriptor/blender:grease-pencil-v3 into main 2023-05-30 11:14:22 +02:00
Conversation 8 Commits 224 Files Changed 94 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 7257549ded - Show all commits

4
source/blender/makesdna/DNA_grease_pencil_types.h
View File

@ -109,8 +109,8 @@ typedef struct GreasePencilDrawing {
/**
* A buffer for a single stroke while drawing.
*/
blender::Span<blender::bke::StrokePoint> stroke_buffer();
bool has_stroke_buffer();
blender::Span<blender::bke::StrokePoint> stroke_buffer() const;
Hans Goudey commented 2023-04-25 04:39:38 +02:00
Outdated
Review
Copy Link

What about a single function that returned std::optional rather than a separate "has_" function?

What about a single function that returned `std::optional` rather than a separate "has_" function?
bool has_stroke_buffer() const;
Hans Goudey commented 2023-04-25 04:40:28 +02:00
Outdated
Review
Copy Link

Looks like stroke_buffer() can be const

Looks like `stroke_buffer()` can be `const`
#endif
} GreasePencilDrawing;