blender
/
blender
136
407
Fork 589
Code Issues 6.3k Pull Requests 768 Projects 19 Wiki Activity

CurvesGeometry: Add initial vertex group support #106944

Merged
Falk David merged 24 commits from filedescriptor/blender:curves-deform-verts into main 2023-09-27 10:26:16 +02:00
Conversation 3 Commits 24 Files Changed 7 +4 -2
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3deeeb6633 - Show all commits

6
source/blender/blenkernel/intern/curves_geometry.cc
View File

@ -61,6 +61,10 @@ CurvesGeometry::CurvesGeometry(const int point_num, const int curve_num)
CustomData_reset(&this->point_data);
CustomData_reset(&this->curve_data);
/* Make sure to clear this before using the attributes API. Otherwise the vertex group accessor
filedescriptor marked this conversation as resolved Outdated
Hans Goudey commented 2023-09-11 18:30:33 +02:00
Outdated
Review
Copy Link

Not sure this comment is really necessary, it's just the same thing as the CustomData_reset calls above.

Not sure this comment is really necessary, it's just the same thing as the `CustomData_reset` calls above.
* might try to read from invalid memory. */
BLI_listbase_clear(&this->vertex_group_names);
this->attributes_for_write().add<float3>(
"position", ATTR_DOMAIN_POINT, AttributeInitConstruct());
@ -82,8 +86,6 @@ CurvesGeometry::CurvesGeometry(const int point_num, const int curve_num)
this->curve_offsets = nullptr;
}
BLI_listbase_clear(&this->vertex_group_names);
/* Fill the type counts with the default so they're in a valid state. */
this->runtime->type_counts[CURVE_TYPE_CATMULL_ROM] = curve_num;
}