blender/blender
148
474
Fork 697
Code Issues 6.7k Pull Requests 883 Projects 18 Wiki Activity

CurvesGeometry: Add initial vertex group support #106944

Merged
Falk David merged 24 commits from filedescriptor/blender:curves-deform-verts into main 2023-09-27 10:26:16 +02:00
Conversation 3 Commits 24 Files Changed 7 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 832ca4bc05 - Show all commits

2
source/blender/blenkernel/intern/curves_geometry.cc
View File

@ -151,9 +151,9 @@ static void move_curves_geometry(CurvesGeometry &dst, CurvesGeometry &src)
std::swap(dst.curve_offsets, src.curve_offsets);
dst.vertex_group_active_index = src.vertex_group_active_index;
std::swap(dst.vertex_group_names.first, src.vertex_group_names.first);
filedescriptor marked this conversation as resolved
Hans Goudey commented 2023-09-26 14:52:28 +02:00
Review
Copy Link

src.vertex_group_active_index = 0; That part is unnecessary I think

`src.vertex_group_active_index = 0;` That part is unnecessary I think
std::swap(dst.vertex_group_names.last, src.vertex_group_names.last);
filedescriptor marked this conversation as resolved Outdated
Hans Goudey commented 2023-09-11 18:31:41 +02:00
Outdated
Review
Copy Link

Can just keep it simpler by swapping everything.

std::swap(dst.vertex_group_names, src.vertex_group_names);
std::swap(dst.vertex_group_active_index, src.vertex_group_active_index);
Can just keep it simpler by swapping everything. ``` std::swap(dst.vertex_group_names, src.vertex_group_names); std::swap(dst.vertex_group_active_index, src.vertex_group_active_index); ```
std::swap(dst.vertex_group_active_index, src.vertex_group_active_index);
src.vertex_group_active_index = 0;
std::swap(dst.runtime, src.runtime);