blender
/
blender
135
400
Fork 583
Code Issues 6.3k Pull Requests 758 Projects 19 Wiki Activity

Compositor: add new node: Kuwahara filter #107015

Merged
Habib Gahbiche merged 22 commits from zazizizou/blender:com-kuwahara-filter-node into main 2023-06-08 16:14:51 +02:00
Conversation 14 Commits 22 Files Changed 19 +18 -12
6 changed files with 18 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8f8a430a5d - Show all commits

5
source/blender/compositor/nodes/COM_KuwaharaNode.cc
View File

@ -1,5 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-or-later
* Copyright 2023 Blender Foundation. */
/* SPDX-FileCopyrightText: 2023 Blender Foundation
*
zazizizou marked this conversation as resolved Outdated
Sergey Sharybin commented 2023-04-20 09:27:36 +02:00
Outdated
Review
Copy Link

Use the current year for the new files added. This also applies to other new files in this PR.

Use the current year for the new files added. This also applies to other new files in this PR.
* SPDX-License-Identifier: GPL-2.0-or-later */
#include "COM_KuwaharaNode.h"
#include "COM_FastGaussianBlurOperation.h"

5
source/blender/compositor/nodes/COM_KuwaharaNode.h
View File

@ -1,5 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-or-later
* Copyright 2023 Blender Foundation. */
/* SPDX-FileCopyrightText: 2023 Blender Foundation
*
zazizizou marked this conversation as resolved Outdated
Sergey Sharybin commented 2023-05-04 11:09:47 +02:00
Outdated
Review
Copy Link

2023

2023
* SPDX-License-Identifier: GPL-2.0-or-later */
#pragma once

5
source/blender/compositor/operations/COM_KuwaharaAnisotropicOperation.cc
View File

@ -1,5 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-or-later
* Copyright 2023 Blender Foundation. */
/* SPDX-FileCopyrightText: 2023 Blender Foundation
*
* SPDX-License-Identifier: GPL-2.0-or-later */
#include "COM_KuwaharaAnisotropicOperation.h"
#include "BLI_math_base.hh"

5
source/blender/compositor/operations/COM_KuwaharaAnisotropicOperation.h
View File

@ -1,5 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-or-later
* Copyright 2023 Blender Foundation. */
/* SPDX-FileCopyrightText: 2023 Blender Foundation
*
* SPDX-License-Identifier: GPL-2.0-or-later */
#pragma once

5
source/blender/compositor/operations/COM_KuwaharaClassicOperation.cc
View File

@ -1,5 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-or-later
* Copyright 2023 Blender Foundation. */
/* SPDX-FileCopyrightText: 2023 Blender Foundation
*
* SPDX-License-Identifier: GPL-2.0-or-later */
#include "COM_KuwaharaClassicOperation.h"
zazizizou marked this conversation as resolved Outdated
Sergey Sharybin commented 2023-06-07 12:28:25 +02:00
Outdated
Review
Copy Link

No need to `extern "C"`` here, the header does it already.

Generally, we should not be adding such statements around #include statements, as it makes it very easy to break things when things move to C++. Some headers might need the linking specializer, and for those it is to be changed in the header itself.

No need to `extern "C"`` here, the header does it already. Generally, we should not be adding such statements around `#include` statements, as it makes it very easy to break things when things move to C++. Some headers might need the linking specializer, and for those it is to be changed in the header itself.

5
source/blender/compositor/operations/COM_KuwaharaClassicOperation.h
View File

@ -1,5 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-or-later
* Copyright 2023 Blender Foundation. */
/* SPDX-FileCopyrightText: 2023 Blender Foundation
*
* SPDX-License-Identifier: GPL-2.0-or-later */
#pragma once