blender
/
blender
136
426
Fork 613
Code Issues 6.3k Pull Requests 780 Projects 19 Wiki Activity

GPencil: Improve random Vertex Color to treat dark color better. #107315

Open
casey-bianco-davis wants to merge 2 commits from casey-bianco-davis/blender:temp-gpencil-random-vertex-color into main
pull from: casey-bianco-davis/blender:temp-gpencil-random-vertex-color
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 1 Commits 2 Files Changed 1 +8 -1
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2f285ab03a - Show all commits

9
source/blender/editors/gpencil_legacy/gpencil_utils.c
View File

@ -2930,7 +2930,14 @@ static void gpencil_sbuffer_vertex_color_random(
}
rgb_to_hsv_v(tpt->vert_color, hsv);
add_v3_v3(hsv, factor_value);
/* Hue and Saturation can just be added; but Value should be multiplied
* because we want the ratio of the origin to modified value to not depend on the origin Value.
* Exp is used because we need a function that is positive
* and has the property that 'f(-x) = 1/f(x)' */
hsv[0] += factor_value[0];
hsv[1] += factor_value[1];
hsv[2] *= exp(factor_value[2]);
/* For Hue need to cover all range, but for Saturation and Value
* is not logic because the effect is too hard, so the value is just clamped. */
if (hsv[0] < 0.0f) {