blender
/
blender
136
406
Fork 589
Code Issues 6.3k Pull Requests 766 Projects 19 Wiki Activity

Fix: Knife tool does not interpolate vertex customdata in interior cuts #107367

Merged
Philipp Oeser merged 3 commits from lichtwerk/blender:BM_edgenet_vdata_support_makes_knife_support_vgrous_in_face_cuts into main 2023-04-27 09:24:09 +02:00
Conversation 3 Commits 3 Files Changed 1 +2 -7
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b3e9882cc2 - Show all commits

9
source/blender/bmesh/intern/bmesh_polygon_edgenet.c
View File

@ -576,13 +576,8 @@ bool BM_face_split_edgenet(BMesh *bm,
BMLoop *l_other;
/* See: #BM_loop_interp_from_face for similar logic. */
void **blocks, **vblocks;
if (has_interp_ldata) {
blocks = BLI_array_alloca(blocks, f->len);
}
if (has_interp_vdata) {
vblocks = BLI_array_alloca(blocks, f->len);
}
void **blocks = has_interp_ldata ? BLI_array_alloca(blocks, f->len) : NULL;
Campbell Barton commented 2023-04-27 02:45:44 +02:00
Outdated
Review
Copy Link

Prefer void **blocks = has_interp_ldata ? BLI_array_alloca(blocks, f->len) : NULL; - uses less space & doesn't leave unassigned.

Prefer `void **blocks = has_interp_ldata ? BLI_array_alloca(blocks, f->len) : NULL;` - uses less space & doesn't leave unassigned.
void **vblocks = has_interp_vdata ? BLI_array_alloca(blocks, f->len) : NULL;
float(*cos_2d)[2] = BLI_array_alloca(cos_2d, f->len);
float *w = BLI_array_alloca(w, f->len);
float axis_mat[3][3];