blender
/
blender
136
411
Fork 595
Code Issues 6.3k Pull Requests 775 Projects 19 Wiki Activity

Shadow linking: Initial work towards MIS support #107439

Merged
Sergey Sharybin merged 17 commits from Sergey/blender:cycles-light-linking-mis into cycles-light-linking 2023-05-05 21:44:14 +02:00
Conversation 8 Commits 17 Files Changed 33 +1 -2
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 1f31187450 - Show all commits

3
intern/cycles/kernel/integrator/shade_blocked_light.h
View File

@ -67,8 +67,7 @@ ccl_device void shadow_linking_shade(KernelGlobals kg, IntegratorState state)
/* MIS weighting. */
float mis_weight = 1.0f;
if (!(path_flag & PATH_RAY_MIS_SKIP)) {
const float mis_ray_pdf = INTEGRATOR_STATE(state, path, mis_ray_pdf);
mis_weight = light_sample_mis_weight_nee(kg, ls.pdf, mis_ray_pdf);
mis_weight = light_sample_mis_weight_forward_lamp(kg, state, path_flag, &ls, ray.P);
}
Brecht Van Lommel commented 2023-05-03 18:45:43 +02:00
Outdated
Review
Copy Link

This should be light_sample_mis_weight_forward_lamp.

The ray direction was chosen by BSDF sampling (forward), not light sampling (next event estimation).

This should be `light_sample_mis_weight_forward_lamp`. The ray direction was chosen by BSDF sampling (forward), not light sampling (next event estimation).
const Spectrum bsdf_spectrum = light_eval * mis_weight;