blender
/
blender
136
413
Fork 596
Code Issues 6.3k Pull Requests 771 Projects 19 Wiki Activity

Fix #107123: Refactor sculpt normal calculation to require vert poly map #107458

Merged
Joseph Eagar merged 6 commits from HooglyBoogly/blender:pbvh-faces-normals-fix-alternate into main 2023-05-09 22:36:37 +02:00
Conversation 0 Commits 6 Files Changed 3 +4 -3
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 08acc45f93 - Show all commits

7
source/blender/blenkernel/intern/pbvh.cc
View File

@ -1420,9 +1420,10 @@ static void pbvh_faces_update_normals(PBVH *pbvh, Span<PBVHNode *> nodes)
for (const int poly : polys_to_update) {
Joseph Eagar commented 2023-04-29 23:20:52 +02:00
Outdated
Review
Copy Link

We can't afford to iterate over all the verts of the mesh here. It's better to build a list of verts to update from the PBVH nodes.

We can't afford to iterate over all the verts of the mesh here. It's better to build a list of verts to update from the PBVH nodes.
👍 1
Joseph Eagar commented 2023-05-01 00:27:39 +02:00
Outdated
Review
Copy Link

The list doesn't have to be unique btw, there's no point going through the effort to eliminate duplicates.

The list doesn't have to be unique btw, there's no point going through the effort to eliminate duplicates.
Hans Goudey commented 2023-05-01 01:50:23 +02:00
Outdated
Review
Copy Link

Well, since a face usually has four corners, not de-duplicating will mean we have to do 4x the calculations, for both vertices and faces. I didn't benchmark it yet, but I'll bet using VectorSet to de-duplicate is worth it here.

Well, since a face usually has four corners, not de-duplicating will mean we have to do 4x the calculations, for both vertices and faces. I didn't benchmark it yet, but I'll bet using `VectorSet` to de-duplicate is worth it here.
Joseph Eagar commented 2023-05-01 22:23:30 +02:00
Outdated
Review
Copy Link

Hrm, you might be right.

Hrm, you might be right.
verts_to_update.add_multiple(corner_verts.slice(polys[poly]));
}
},
[&]() {
update_tags.fill(false);
for (const int vert : verts_to_update) {
update_tags[vert] = false;
Joseph Eagar commented 2023-05-01 22:17:54 +02:00
Outdated
Review
Copy Link

Use verts_to_update or the node unique verts to clear the update tags.

Use `verts_to_update` or the node unique verts to clear the update tags.
}
for (PBVHNode *node : nodes) {
node->flag &= ~PBVH_UpdateNormals;
}