blender
/
blender
135
420
Fork 602
Code Issues 6.3k Pull Requests 763 Projects 19 Wiki Activity

Refactor ImBuf buffer access #107609

Merged
Sergey Sharybin merged 8 commits from Sergey/blender:imbuf_buffer_data_refactor into main 2023-05-18 10:19:10 +02:00
Conversation 8 Commits 8 Files Changed 121 +2 -2
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b7a57cd599 - Show all commits

2
source/blender/blenkernel/intern/image.cc
View File

@ -4457,7 +4457,7 @@ static ImBuf *image_get_render_result(Image *ima, ImageUser *iuser, void **r_loc
IMB_assign_float_z_buffer(ibuf, rectz, IB_DO_NOT_TAKE_OWNERSHIP);
/* TODO(sergey): Make this faster by either simply referencing the stamp
* or by changing both ImBug and RenderResult to use same data type to
* or by changing both ImBuf and RenderResult to use same data type to
* store metadata. */
if (ibuf->metadata != nullptr) {
IMB_metadata_free(ibuf->metadata);

2
source/blender/imbuf/IMB_imbuf_types.h
View File

@ -160,7 +160,7 @@ typedef enum eImBufFlags {
/* Specialization of an ownership whenever a bare pointer is provided to the ImBuf buffers
* assignment API. */
typedef enum ImBufOwnership {
Jeroen Bakker commented 2023-05-08 08:59:10 +02:00
Review
Copy Link

Naming might be confusing as the enum name can be read as a state type, but the values represent an action/transition.

Naming might be confusing as the enum name can be read as a state type, but the values represent an action/transition.
/* The ImBug simply shares pointer with data owned by someone else, and will not perform any
/* The ImBuf simply shares pointer with data owned by someone else, and will not perform any
Jeroen Bakker commented 2023-05-08 08:55:38 +02:00
Outdated
Review
Copy Link

ImBuf

`ImBuf`
* memory management when the ImBuf frees the buffer. */
IB_DO_NOT_TAKE_OWNERSHIP = 0,