blender
/
blender
136
413
Fork 596
Code Issues 6.3k Pull Requests 771 Projects 19 Wiki Activity

UI: support operator enums in Quick Favorites #107616

Merged
Philipp Oeser merged 5 commits from lichtwerk/blender:59244 into main 2023-05-08 09:14:52 +02:00
Conversation 2 Commits 5 Files Changed 4 +7
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8ae4fa4436 - Show all commits

5
source/blender/editors/include/ED_screen.h
View File

@ -609,6 +609,11 @@ bool ED_operator_camera_poll(struct bContext *C);
bUserMenu **ED_screen_user_menus_find(const struct bContext *C, uint *r_len);
struct bUserMenu *ED_screen_user_menu_ensure(struct bContext *C);
/** Finds a menu item associated with an operator in user menus (aka Quick Favorites)
*
* \param op_prop_enum: name of an operator property when the operator is called with an enum (to
* be an empty string otherwise)
Campbell Barton commented 2023-05-04 16:25:40 +02:00
Outdated
Review
Copy Link

Doc-string should note this is to be an empty string when not set.

Doc-string should note this is to be an empty string when not set.
Philipp Oeser commented 2023-05-05 12:22:45 +02:00
Outdated
Review
Copy Link

done

done
*/
struct bUserMenuItem_Op *ED_screen_user_menu_item_find_operator(struct ListBase *lb,
const struct wmOperatorType *ot,
struct IDProperty *prop,

2
source/blender/editors/screen/screen_user_menu.c
View File

@ -235,6 +235,8 @@ static void screen_user_menu_draw(const bContext *C, Menu *menu)
NULL);
}
else {
/* umi_op->prop could be used to set other properties but it's currently unsupported.
*/
uiItemMenuEnumFullO_ptr(menu->layout,
Campbell Barton commented 2023-05-04 16:32:59 +02:00
Review
Copy Link

It's possible we want to support assigning additional properties even with op_prop_enum set, although I'm not sure if there are practical cases which would use this of hand.

Nevertheless, it's worth adding a comment that umi_op->prop could be used to set other properties but it's currently unsupported.

It's possible we want to support assigning additional properties even with `op_prop_enum` set, although I'm not sure if there are practical cases which would use this of hand. Nevertheless, it's worth adding a comment that `umi_op->prop` could be used to set other properties but it's currently unsupported.
Philipp Oeser commented 2023-05-05 12:24:44 +02:00
Review
Copy Link

added that comment

added that comment
C,
ot,