blender
/
blender
136
411
Fork 595
Code Issues 6.3k Pull Requests 771 Projects 19 Wiki Activity

Mesh: Reimplement and unify topology maps #107861

Merged
Hans Goudey merged 14 commits from HooglyBoogly/blender:cleanup-unify-mesh-maps into main 2023-05-24 13:17:03 +02:00
Conversation 3 Commits 14 Files Changed 48 +3 -3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 0d645238d5 - Show all commits

6
source/blender/blenlib/BLI_offset_indices.hh
View File

@ -107,17 +107,17 @@ template<typename T> struct GroupedSpan {
GroupedSpan() = default;
HooglyBoogly marked this conversation as resolved
Jacques Lucke commented 2023-05-22 12:57:16 +02:00
Review
Copy Link

Use this-> when refering to public data members.

Use `this->` when refering to public data members.
GroupedSpan(OffsetIndices<int> offsets, Span<T> data) : offsets(offsets), data(data)
{
BLI_assert(offsets.total_size() == data.size());
BLI_assert(this->offsets.total_size() == this->data.size());
HooglyBoogly marked this conversation as resolved Outdated
Jacques Lucke commented 2023-05-22 13:00:29 +02:00
Outdated
Review
Copy Link

vert_index -> index

`vert_index` -> `index`
}
Span<T> operator[](const int64_t index) const
{
return data.slice(offsets[index]);
return this->data.slice(this->offsets[index]);
HooglyBoogly marked this conversation as resolved Outdated
Jacques Lucke commented 2023-05-22 13:01:05 +02:00
Outdated
Review
Copy Link

Also add a size and index_range method.

Also add a `size` and `index_range` method.
}
bool is_empty() const
{
return data.size() == 0;
return this->data.size() == 0;
}
};