blender
/
blender
134
402
Fork 585
Code Issues 6.3k Pull Requests 759 Projects 19 Wiki Activity

Fix #108049: De-duplicate copied active node #108082

Closed
Iliya Katushenock wants to merge 6 commits from mod_moder:tmp_fix_deduplicate_active_node_of_copys into main
pull from: mod_moder:tmp_fix_deduplicate_active_node_of_copys
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 4 Commits 6 Files Changed 2 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 45733e4d5f - Show all commits

4
source/blender/editors/space_node/node_edit.cc
View File

@ -1295,7 +1295,7 @@ static int node_duplicate_exec(bContext *C, wmOperator *op)
Map<const bNodeSocket *, bNodeSocket *> socket_map;
Map<const ID *, ID *> duplicated_node_groups;
bNode *actibe_node = nodeGetActive(ntree);
bNode *active_node = nodeGetActive(ntree);
mod_moder marked this conversation as resolved
Lukas Tönne commented 2023-05-22 15:07:02 +02:00
Review
Copy Link

typo: actibe

typo: acti**b**e
😆 1
for (bNode *node : get_selected_nodes(*ntree)) {
bNode *new_node = bke::node_copy_with_mapping(
@ -1372,7 +1372,7 @@ static int node_duplicate_exec(bContext *C, wmOperator *op)
remap_pairing(*ntree, node_map);
if (bNode *new_active_node = node_map.lookup_default(actibe_node, nullptr)) {
if (bNode *new_active_node = node_map.lookup_default(active_node, nullptr)) {
nodeSetActive(ntree, new_active_node);
}