blender
/
blender
137
411
Fork 594
Code Issues 6.3k Pull Requests 770 Projects 19 Wiki Activity

Fix #108591: Handle null material adding paint slot #108592

Merged
YimingWu merged 5 commits from ChengduLittleA/blender:fix-108591 into blender-v3.6-release 2023-06-06 04:13:08 +02:00
Conversation 6 Commits 5 Files Changed 1 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ee6de70bdc - Show all commits

2
source/blender/editors/sculpt_paint/paint_image_proj.cc
View File

@ -6641,7 +6641,7 @@ static void default_paint_slot_color_get(int layer_type, Material *ma, float col
if (ma && ma->nodetree) {
ma->nodetree->ensure_topology_cache();
const blender::Span<bNode *> nodes = ma->nodetree->nodes_by_type("ShaderNodeBsdfPrincipled");
nodes.is_empty() ? nullptr : nodes.first();
in_node = nodes.is_empty() ? nullptr : nodes.first();
ChengduLittleA marked this conversation as resolved Outdated
Hans Goudey commented 2023-06-05 16:19:51 +02:00
Outdated
Review
Copy Link

Am I missing something? nodes.is_empty() ? nullptr : nodes.first(); doesn't seem to do anything

Am I missing something? `nodes.is_empty() ? nullptr : nodes.first();` doesn't seem to do anything
}
if (!in_node) {
/* An existing material or Principled BSDF node could not be found.