blender
/
blender
135
403
Fork 586
Code Issues 6.2k Pull Requests 756 Projects 19 Wiki Activity

Attributes: Add quaternion rotation type #108678

Merged
Hans Goudey merged 10 commits from HooglyBoogly/blender:attributes-quaternion-type into main 2023-06-12 15:49:57 +02:00
Conversation 3 Commits 10 Files Changed 16 -10
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 7ae3074bd9 - Show all commits

10
source/blender/blenlib/BLI_math_quaternion.hh
View File

@ -669,16 +669,6 @@ template<typename T> Euler3Base<T> to_euler(const QuaternionBase<T> &quat, Euler
/** \name Conversion from/to Expmap
* \{ */
template<typename T> T mod_inline(const T a, const T b)
{
return a - (b * math::floor(a / b));
}
template<typename T> T angle_wrap_rad(const T angle)
{
return mod_inline(angle + float(M_PI), float(M_PI) * 2.0f) - float(M_PI);
}
/* Prototype needed to avoid interdependencies of headers. */
HooglyBoogly marked this conversation as resolved Outdated
Jacques Lucke commented 2023-06-08 21:57:11 +02:00
Outdated
Review
Copy Link

Missing inline keyword. Same below. Also a comment would be useful. Not really obvious to me what mod_inline means.

Missing `inline` keyword. Same below. Also a comment would be useful. Not really obvious to me what `mod_inline` means.
template<typename T, typename AngleT>
QuaternionBase<T> to_quaternion(const AxisAngleBase<T, AngleT> &axis_angle);