blender
/
blender
136
407
Fork 589
Code Issues 6.3k Pull Requests 779 Projects 19 Wiki Activity

Fix #106395: Custom properties dont appear in quick favorites #108713

Merged
Philipp Oeser merged 2 commits from lichtwerk/blender:106395 into blender-v3.6-release 2023-06-08 10:37:42 +02:00
Conversation 0 Commits 2 Files Changed 1 +2
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3cfa9914fa - Show all commits

2
source/blender/editors/interface/interface_context_menu.cc
View File

@ -343,6 +343,7 @@ static bUserMenuItem *ui_but_user_menu_find(bContext *C, uiBut *but, bUserMenu *
}
if (but->rnaprop) {
char *member_id_data_path = WM_context_path_resolve_full(C, &but->rnapoin);
/* Ignore the actual array index [pass -1] since the index is handled separately. */
const char *prop_id = RNA_property_is_idprop(but->rnaprop) ?
Campbell Barton commented 2023-06-08 03:20:52 +02:00
Review
Copy Link

Please include a comment that the array index is handled separately, otherwise this reads as if arrays indices are aren't supported.

Please include a comment that the array index is handled separately, otherwise this reads as if arrays indices are aren't supported.
RNA_path_property_py(&but->rnapoin, but->rnaprop, -1) :
RNA_property_identifier(but->rnaprop);
@ -420,6 +421,7 @@ static void ui_but_user_menu_add(bContext *C, uiBut *but, bUserMenu *um)
else if (but->rnaprop) {
/* NOTE: 'member_id' may be a path. */
char *member_id_data_path = WM_context_path_resolve_full(C, &but->rnapoin);
/* Ignore the actual array index [pass -1] since the index is handled separately. */
const char *prop_id = RNA_property_is_idprop(but->rnaprop) ?
RNA_path_property_py(&but->rnapoin, but->rnaprop, -1) :
RNA_property_identifier(but->rnaprop);