blender
/
blender
134
422
Fork 604
Code Issues 6.4k Pull Requests 763 Projects 19 Wiki Activity

Geometry Nodes: Avoid index lookup from index mask #109174

Merged
Hans Goudey merged 9 commits from mod_moder/blender:avoid_mask_lookup into main 2023-06-23 19:20:30 +02:00
Conversation 4 Commits 9 Files Changed 10 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d2ab277e2d - Show all commits

4
source/blender/nodes/geometry/nodes/node_geo_extrude_mesh.cc
View File

@ -1256,8 +1256,8 @@ static void extrude_individual_mesh_faces(
using T = decltype(dummy);
MutableSpan<T> data = attribute.span.typed<T>();
MutableSpan<T> connect_data = data.slice(connect_edge_range);
poly_selection.foreach_index_optimized<int>(
GrainSize(512), [&](const int index, const int i_selection) {
poly_selection.foreach_index(
mod_moder marked this conversation as resolved Outdated
Jacques Lucke commented 2023-06-21 09:22:37 +02:00
Outdated
Review
Copy Link

How much of a speedup do you get here from using optimized?

How much of a speedup do you get here from using `optimized`?
Iliya Katushenock commented 2023-06-21 13:02:02 +02:00
Outdated
Review
Copy Link

Haven't done any tests yet. But here, most likely, I simply overlooked the nested loop.

Haven't done any tests yet. But here, most likely, I simply overlooked the nested loop.
GrainSize(512), [&](const int64_t index, const int64_t i_selection) {
const IndexRange poly = polys[index];
const IndexRange extrude_range = group_per_face[i_selection];