blender
/
blender
137
418
Fork 600
Code Issues 6.3k Pull Requests 782 Projects 19 Wiki Activity

GPv3: Select Alternate #109240

Merged
Falk David merged 6 commits from Lorenzo-Carpaneto/blender:gpv3-select-alternate into main 2023-06-23 11:34:06 +02:00
Conversation 1 Commits 6 Files Changed 4 +4
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b6523945bc - Show all commits

4
source/blender/editors/curves/intern/curves_selection.cc
View File

@ -274,6 +274,10 @@ void select_linked(bke::CurvesGeometry &curves)
void select_alternate(bke::CurvesGeometry &curves, const bool deselect_ends)
{
if (!has_anything_selected(curves)) {
return;
}
const OffsetIndices points_by_curve = curves.points_by_curve();
Lorenzo-Carpaneto marked this conversation as resolved Outdated
Falk David commented 2023-06-22 14:20:21 +02:00
Outdated
Review
Copy Link

The ensure_selection_attribute call already makes sure we have a bool attribute. No need for the assert here.

The `ensure_selection_attribute` call already makes sure we have a `bool` attribute. No need for the assert here.
Hans Goudey commented 2023-06-22 15:44:50 +02:00
Outdated
Review
Copy Link

It doesn't actually. The type argument is only used when the selection attribute doesn't exist yet. So if the selection already has a float type, this operator will have to support that or change the attribute's type to boolean.

It doesn't actually. The type argument is only used when the selection attribute doesn't exist yet. So if the selection already has a float type, this operator will have to support that or change the attribute's type to boolean.
😆 1
Lorenzo-Carpaneto commented 2023-06-22 16:50:36 +02:00
Outdated
Review
Copy Link

what do we want to do? We could template the function and support both selection; we could change the selection type, we could do nothing and prevent the user to use this if the type of selection isn't bool...

what do we want to do? We could template the function and support both selection; we could change the selection type, we could do nothing and prevent the user to use this if the type of selection isn't bool...
Falk David commented 2023-06-22 17:21:36 +02:00
Outdated
Review
Copy Link

Since there is no exposed way of creating a float selection at the moment, I would just remove the assert and leave it as is.

Since there is no exposed way of creating a `float` selection at the moment, I would just remove the assert and leave it as is.
Lorenzo-Carpaneto commented 2023-06-22 17:30:23 +02:00
Outdated
Review
Copy Link

Then we are ready to merge this pr I think :)

Then we are ready to merge this pr I think :)
bke::GSpanAttributeWriter selection = ensure_selection_attribute(
curves, ATTR_DOMAIN_POINT, CD_PROP_BOOL);
Lorenzo-Carpaneto marked this conversation as resolved
Pratik Borhade commented 2023-06-24 11:57:07 +02:00
Review
Copy Link

Hi, looks like this operator is only supported in point selection mode.
In that case, we could change the poll function to editable_grease_pencil_point_selection_poll

Hi, looks like this operator is only supported in point selection mode. In that case, we could change the poll function to `editable_grease_pencil_point_selection_poll`
👍 1
Falk David commented 2023-06-24 13:16:36 +02:00
Review
Copy Link

That is correct, yes. Should be changed.

That is correct, yes. Should be changed.
👍 2
Pratik Borhade commented 2023-06-24 13:35:25 +02:00
Review
Copy Link

I'll commit then directly? (or want a PR again?)

Edit: pushed to main: 51a5be8913

I'll commit then directly? (or want a PR again?) Edit: pushed to main: 51a5be891308e174e2bd8bc862bdde41545b08d1
❤️ 1
Falk David commented 2023-06-24 17:12:46 +02:00
Review
Copy Link

Thank you @PratikPB2123

Thank you @PratikPB2123
👍 1