blender
/
blender
134
422
Fork 605
Code Issues 6.4k Pull Requests 767 Projects 19 Wiki Activity

GPv3: Insert grease pencil keyframe from the dopesheet #110649

Merged
Amélie Fondevilla merged 23 commits from amelief/blender:gpv3-insert-keyframe into main 2023-08-02 14:56:24 +02:00
Conversation 1 Commits 23 Files Changed 5 +1 -2
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d92f42eb5c - Show all commits

3
source/blender/editors/space_action/action_edit.cc
View File

@ -779,8 +779,7 @@ static void insert_grease_pencil_key(bAnimContext *ac,
GreasePencil *grease_pencil = reinterpret_cast<GreasePencil *>(ale->id);
const int frame_number = ac->scene->r.cfra;
amelief marked this conversation as resolved Outdated
Falk David commented 2023-08-01 12:47:47 +02:00
Outdated
Review
Copy Link

Even if it's a bit longer, I would prefer this to be current_frame_number. Makes the rest more readable imho.

Even if it's a bit longer, I would prefer this to be `current_frame_number`. Makes the rest more readable imho.
const GreasePencilFrame *current_frame = layer->frames().lookup_ptr(frame_number);
if (current_frame != nullptr) {
if (layer->frames().contains(frame_number)) {
/* A frame already exists at the current frame number. */
amelief marked this conversation as resolved Outdated
Falk David commented 2023-08-01 12:48:21 +02:00
Outdated
Review
Copy Link

This comment can be removed with the change suggested above.

This comment can be removed with the change suggested above.
return;
}