blender/blender
148
469
Fork 680
Code Issues 6.7k Pull Requests 884 Projects 18 Wiki Activity

GPv3: Cyclical set operator #111904

Merged
Falk David merged 16 commits from casey-bianco-davis/blender:GPv3-cyclical-set-operator into main 2023-10-20 10:12:34 +02:00
Conversation 3 Commits 16 Files Changed 5 +3 -1
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8f45f2f5b7 - Show all commits

4
source/blender/editors/grease_pencil/intern/grease_pencil_edit.cc
View File

@ -914,7 +914,9 @@ static int grease_pencil_cyclical_set_exec(bContext *C, wmOperator *op)
}
/* Remove the attribute if it is empty. */
if (!ed::curves::has_anything_selected(curves.cyclic(), curves.curves_range())) {
if (mode != CyclicalMode::CLOSE &&
casey-bianco-davis marked this conversation as resolved Outdated
Hans Goudey commented 2023-10-19 09:32:04 +02:00
Outdated
Review
Copy Link

This doesn't need to run in "Close" mode.

This doesn't need to run in "Close" mode.
!ed::curves::has_anything_selected(curves.cyclic(), curves.curves_range()))
{
curves.attributes_for_write().remove("cyclic");
}