blender/blender
142
451
Fork 651
Code Issues 6.5k Pull Requests 824 Projects 18 Wiki Activity

GPv3: Cyclical set operator #111904

Merged
Falk David merged 16 commits from casey-bianco-davis/blender:GPv3-cyclical-set-operator into main 2023-10-20 10:12:34 +02:00
Conversation 3 Commits 16 Files Changed 5 +10
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a56851b9e6 - Show all commits

10
source/blender/editors/grease_pencil/intern/grease_pencil_edit.cc
View File

@ -891,6 +891,11 @@ static int grease_pencil_cyclical_set_exec(bContext *C, wmOperator *op)
return;
}
/* Return to stop from creating unneeded attribute. */
if (mode == CyclicalMode::OPEN && !curves.attributes().contains("cyclic")) {
return;
}
MutableSpan<bool> cyclic = curves.cyclic_for_write();
IndexMaskMemory memory;
@ -908,6 +913,11 @@ static int grease_pencil_cyclical_set_exec(bContext *C, wmOperator *op)
break;
}
/* Remove the attribute if it is empty. */
if (!ed::curves::has_anything_selected(curves.cyclic(), curves.curves_range())) {
casey-bianco-davis marked this conversation as resolved Outdated
Hans Goudey commented 2023-10-19 09:32:04 +02:00
Outdated
Review
Copy Link

This doesn't need to run in "Close" mode.

This doesn't need to run in "Close" mode.
curves.attributes_for_write().remove("cyclic");
}
changed = true;
});