blender
/
blender
136
407
Fork 590
Code Issues 6.3k Pull Requests 777 Projects 19 Wiki Activity

Fix #112083: Loop cut requires GL only in interactive mode #112121

Merged
YimingWu merged 2 commits from ChengduLittleA/blender:fix-112083 into main 2023-09-18 15:45:24 +02:00
Conversation 2 Commits 2 Files Changed 1 +3
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 243c933114 - Show all commits

3
source/blender/editors/mesh/editmesh_loopcut.cc
View File

@ -374,6 +374,9 @@ static void loopcut_mouse_move(RingSelOpData *lcd, const int previewlines)
/* called by both init() and exec() */
static int loopcut_init(bContext *C, wmOperator *op, const wmEvent *event)
{
/* Check whether both `rv3d` and `event` is present, this way we allow the loopcut operator to
* run non-interactively no matter whether the graphical UI is present or not (e.g. from scripts
ChengduLittleA marked this conversation as resolved Outdated
Campbell Barton commented 2023-09-18 15:07:30 +02:00
Outdated
Review
Copy Link

It would be good to note here why check both the rv3d and the event is needed.

It would be good to note here why check both the rv3d and the event is needed.
* with UI running, or entirely in the background with `blender -b`). */
RegionView3D *rv3d = CTX_wm_region_view3d(C);
const bool is_interactive = (rv3d != nullptr) && (event != nullptr);