blender
/
blender
135
420
Fork 603
Code Issues 6.3k Pull Requests 754 Projects 19 Wiki Activity

EEVEE-Next: Rename light probes #113452

Merged
Miguel Pozo merged 9 commits from pragma37/blender:pull-probes-rename into main 2023-10-11 19:38:51 +02:00
Conversation 3 Commits 9 Files Changed 19 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d42f7b1e7c - Show all commits

4
source/blender/makesrna/intern/rna_object.cc
View File

@ -233,8 +233,8 @@ const EnumPropertyItem rna_enum_metaelem_type_items[] = {
};
const EnumPropertyItem rna_enum_lightprobes_type_items[] = {
{LIGHTPROBE_TYPE_SPHERE, "CUBEMAP", ICON_LIGHTPROBE_SPHERE, "Cubemap", ""},
{LIGHTPROBE_TYPE_PLANE, "PLANAR", ICON_LIGHTPROBE_PLANE, "Planar", ""},
{LIGHTPROBE_TYPE_SPHERE, "SPHERE", ICON_LIGHTPROBE_SPHERE, "Sphere", ""},
pragma37 marked this conversation as resolved Outdated
Clément Foucault commented 2023-10-11 15:26:53 +02:00
Outdated
Review
Copy Link

We decide to change the name and enum. so SPHERE and "Sphere"

EDIT: That this changes more python areas. Do we really want to do that right now? I would say yes.

We decide to change the name and enum. so `SPHERE` and "Sphere" EDIT: That this changes more python areas. Do we really want to do that right now? I would say yes.
{LIGHTPROBE_TYPE_PLANE, "PLANE", ICON_LIGHTPROBE_PLANE, "Plane", ""},
pragma37 marked this conversation as resolved Outdated
Clément Foucault commented 2023-10-11 15:27:09 +02:00
Outdated
Review
Copy Link

PLANE and Plane

`PLANE` and `Plane`
{LIGHTPROBE_TYPE_VOLUME, "VOLUME", ICON_LIGHTPROBE_VOLUME, "Volume", ""},
Clément Foucault commented 2023-10-11 01:11:18 +02:00
Outdated
Review
Copy Link

Uppercase VOLUME in name. Should be title case.

Uppercase VOLUME in name. Should be title case.
{0, nullptr, 0, nullptr, nullptr},
};