blender
/
blender
135
420
Fork 601
Code Issues 6.3k Pull Requests 764 Projects 19 Wiki Activity

Fix #114780: Cycles: Principled Chiang Hair importance sampling correction #115241

Merged
Weizhen Huang merged 12 commits from HamilcarR/blender:cycles-114780_chiang-hair into main 2024-05-27 09:35:44 +02:00
Conversation 10 Commits 12 Files Changed 2 +1 -3
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ea85357491 - Show all commits

4
intern/cycles/kernel/closure/bsdf_principled_hair_chiang.h
View File

@ -395,7 +395,7 @@ ccl_device int bsdf_hair_chiang_sample(KernelGlobals kg,
rand.z = max(rand.z, 1e-5f);
const float fac = 1.0f + v * logf(rand.z + (1.0f - rand.z) * expf(-2.0f / v));
float sin_theta_i = -fac * sintheta_temp_o +
cos_from_sin(fac) * cosf(M_2PI_F * rand.y) * costheta_temp_o;
sin_from_cos(fac) * cosf(M_2PI_F * rand.y) * costheta_temp_o;
HamilcarR marked this conversation as resolved Outdated
Weizhen Huang commented 2024-03-18 11:42:03 +01:00
Outdated
Review
Copy Link

I do not like this naming, because this variable has a concrete meaning and is therefore not temp, and it does not following the naming convention of the nearby code.
I suggest sin_theta_o_tilted

I do not like this naming, because this variable has a concrete meaning and is therefore not temp, and it does not following the naming convention of the nearby code. I suggest `sin_theta_o_tilted`
Amine Bensalem commented 2024-04-29 19:22:13 +02:00
Outdated
Review
Copy Link

agreed , this was poorly named.

agreed , this was poorly named.
float cos_theta_i = cos_from_sin(sin_theta_i);
float phi;
@ -407,8 +407,6 @@ ccl_device int bsdf_hair_chiang_sample(KernelGlobals kg,
}
const float phi_i = phi_o + phi;
hair_alpha_angles(sin_theta_o, cos_theta_o, bsdf->alpha, angles);
Spectrum F = zero_spectrum();
float F_energy = 0.0f;