blender
/
blender
134
425
Fork 607
Code Issues 6.2k Pull Requests 778 Projects 19 Wiki Activity

Fix #114981 : Add box, circle and lasso selection tools to weight paint + bone select mode #115807

Open
Daiki Hashimoto wants to merge 11 commits from daisea3e1203/blender:add-select-tools-to-bone-select-mode into main
pull from: daisea3e1203/blender:add-select-tools-to-bone-select-mode
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 18 Commits 11 Files Changed 4 +5 -5
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 09a3f4b9b1 - Show all commits

10
source/blender/blenkernel/BKE_paint.hh
View File

@ -200,16 +200,16 @@ void BKE_paint_curve_set(Brush *br, PaintCurve *pc);
void BKE_paint_curve_clamp_endpoint_add_index(PaintCurve *pc, int add_index);
/**
* Return true when in vertex/weight/texture paint + face-select mode?
* Return true when in vertex/weight/texture paint + face-select mode.
*/
bool BKE_paint_select_face_test(const Object *ob);
/**
* Return true when in vertex/weight paint + vertex-select mode?
* Return true when in vertex/weight paint + vertex-select mode.
*/
bool BKE_paint_select_vert_test(const Object *ob);
// /**
// * Return true when in weight paint + bone-select mode?
// */
/**
* Return true when in weight paint + bone-select mode.
daisea3e1203 marked this conversation as resolved Outdated
Christoph Lendenfeld commented 2023-12-08 10:30:49 +01:00
Outdated
Review
Copy Link

The blender comment style is without the double slash (//) at the start

Also I feel like the comment should not be a question. I know this is the same as the functions above,
but it's confusing to read.
I assume its just a statement. As in it returns true when in weight paint + bone-select mode.

The blender comment style is without the double slash (//) at the start Also I feel like the comment should not be a question. I know this is the same as the functions above, but it's confusing to read. I assume its just a statement. As in it returns true when in weight paint + bone-select mode.
👍 1
Daiki Hashimoto commented 2023-12-08 14:26:18 +01:00
Outdated
Review
Copy Link

I applied the same change in 09a3f4b9b1 to the two functions above (change the question mark to a period) since I encountered them many times when coding for this PR, and were used as a statement to check for their respective modes.

I applied the same change in 09a3f4b9b1 to the two functions above (change the question mark to a period) since I encountered them many times when coding for this PR, and were used as a statement to check for their respective modes.
*/
bool BKE_paint_select_bone_test(const Object *ob);
/**