blender
/
blender
136
407
Fork 589
Code Issues 6.3k Pull Requests 777 Projects 19 Wiki Activity

VSE: make Glow effect 6x-10x faster #115818

Merged
Aras Pranckevicius merged 5 commits from aras_p/blender:vse-glow-opt into main 2023-12-06 19:39:51 +01:00
Conversation 4 Commits 5 Files Changed 3 +2 -37
3 changed files with 2 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ebde205d2b - Show all commits

2
source/blender/imbuf/IMB_imbuf.h
View File

@ -643,8 +643,6 @@ void IMB_buffer_byte_from_byte(unsigned char *rect_to,
int height,
int stride_to,
int stride_from);
void IMB_buffer_float_unpremultiply(float *buf, int width, int height);
void IMB_buffer_float_premultiply(float *buf, int width, int height);
/**
* Change the ordering of the color bytes pointed to by rect from

20
source/blender/imbuf/intern/divers.cc
View File

@ -856,26 +856,6 @@ void IMB_color_to_bw(ImBuf *ibuf)
}
}
void IMB_buffer_float_unpremultiply(float *buf, int width, int height)
{
size_t total = size_t(width) * height;
float *fp = buf;
while (total--) {
premul_to_straight_v4(fp);
fp += 4;
}
}
void IMB_buffer_float_premultiply(float *buf, int width, int height)
{
size_t total = size_t(width) * height;
float *fp = buf;
while (total--) {
straight_to_premul_v4(fp);
fp += 4;
}
}
/** \} */
/* -------------------------------------------------------------------- */

17
source/blender/sequencer/intern/effects.cc
View File

@ -2156,19 +2156,7 @@ static void do_glow_effect_byte(Sequence *seq,
MEM_mallocN(sizeof(float[4]) * x * y, "glow effect output"));
using namespace blender;
threading::parallel_for(IndexRange(y), 64, [&](const IndexRange y_range) {
size_t offset = y_range.first() * x * 4;
IMB_buffer_float_from_byte(inbuf + offset,
rect1 + offset,
IB_PROFILE_SRGB,
IB_PROFILE_SRGB,
false,
x,
y_range.size(),
x,
x);
IMB_buffer_float_premultiply(inbuf + offset, x, y_range.size());
});
IMB_colormanagement_transform_from_byte_threaded(inbuf, rect1, x, y, 4, "sRGB", "sRGB");
blur_isolate_highlights(
inbuf, outbuf, x, y, glow->fMini * 3.0f, glow->fBoost * fac, glow->fClamp);
@ -2183,14 +2171,13 @@ static void do_glow_effect_byte(Sequence *seq,
threading::parallel_for(IndexRange(y), 64, [&](const IndexRange y_range) {
size_t offset = y_range.first() * x * 4;
IMB_buffer_float_unpremultiply(outbuf + offset, x, y_range.size());
IMB_buffer_byte_from_float(out + offset,
outbuf + offset,
4,
0.0f,
IB_PROFILE_SRGB,
IB_PROFILE_SRGB,
false,
true,
x,
y_range.size(),
x,