blender
/
blender
136
426
Fork 613
Code Issues 6.3k Pull Requests 780 Projects 19 Wiki Activity

Fix: False positives/negatives in curves_selection.cc#contains #116834

Merged
Hans Goudey merged 5 commits from Mysteryem/blender:fix_curves_selection_contains into main 2024-01-09 17:40:23 +01:00
Conversation 1 Commits 5 Files Changed 1 +2 -1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2108a6b619 - Show all commits

3
source/blender/editors/curves/intern/curves_selection.cc
View File

@ -191,7 +191,8 @@ static bool contains(const VArray<bool> &varray,
return init;
}
constexpr int64_t MaxChunkSize = 512;
Hans Goudey commented 2024-01-09 17:08:30 +01:00
Review
Copy Link

How about using a variable to simplify this a bit:

const int64_t slice_end = range.one_after_last();
How about using a variable to simplify this a bit: ```cpp const int64_t slice_end = range.one_after_last(); ```
for (int64_t start = range.start(); start < range.one_after_last(); start += MaxChunkSize) {
for (int64_t start = range.start(); start < range.one_after_last(); start += MaxChunkSize)
{
const int64_t end = std::min<int64_t>(start + MaxChunkSize, range.one_after_last());
const int64_t size = end - start;
const IndexMask sliced_mask = indices_to_check.slice(start, size);