blender
/
blender
134
421
Fork 604
Code Issues 6.4k Pull Requests 769 Projects 19 Wiki Activity

GPv3: Tint and Color modifiers #117297

Merged
Lukas Tönne merged 20 commits from LukasTonne/blender:gp3-color-modifier into main 2024-01-19 16:59:49 +01:00
Conversation 3 Commits 20 Files Changed 10 +2 -2
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9bbd1c69c5 - Show all commits

2
source/blender/modifiers/intern/MOD_grease_pencil_color.cc
View File

@ -107,7 +107,7 @@ static void modify_stroke_color(Object *ob,
const bool use_curve = (cmd.influence.flag & GREASE_PENCIL_INFLUENCE_USE_CUSTOM_CURVE);
LukasTonne marked this conversation as resolved
Falk David commented 2024-01-19 10:54:36 +01:00
Review
Copy Link

point_colors -> vertex_colors

`point_colors` -> `vertex_colors`
const OffsetIndices<int> points_by_curve = curves.points_by_curve();
bke::MutableAttributeAccessor attributes = curves.attributes_for_write();
bke::AttributeAccessor attributes = curves.attributes();
VArray<int> stroke_materials =
LukasTonne marked this conversation as resolved Outdated
Hans Goudey commented 2024-01-19 14:07:25 +01:00
Outdated
Review
Copy Link

Typically * is used instead of .varray. Just a bit shorter

Typically `*` is used instead of `.varray`. Just a bit shorter
attributes.lookup_or_default<int>("material_index", bke::AttrDomain::Curve, 0).varray;
LukasTonne marked this conversation as resolved Outdated
Falk David commented 2024-01-19 11:07:21 +01:00
Outdated
Review
Copy Link

Looks like you just need attributes() here.

Looks like you just need `attributes()` here.
LukasTonne marked this conversation as resolved
Falk David commented 2024-01-19 11:07:27 +01:00
Review
Copy Link

const

`const`

2
source/blender/modifiers/intern/MOD_grease_pencil_tint.cc
View File

@ -171,7 +171,7 @@ static void modify_stroke_color(Object *ob,
GREASE_PENCIL_INFLUENCE_INVERT_VERTEX_GROUP);
const OffsetIndices<int> points_by_curve = curves.points_by_curve();
bke::MutableAttributeAccessor attributes = curves.attributes_for_write();
bke::AttributeAccessor attributes = curves.attributes();
VArray<int> stroke_materials =
LukasTonne marked this conversation as resolved Outdated
Hans Goudey commented 2024-01-19 14:10:26 +01:00
Outdated
Review
Copy Link

* here instead of .varray too

`*` here instead of `.varray` too
attributes.lookup_or_default<int>("material_index", bke::AttrDomain::Curve, 0).varray;
LukasTonne marked this conversation as resolved Outdated
Falk David commented 2024-01-19 11:05:58 +01:00
Outdated
Review
Copy Link

Looks like you don't need the attributes_for_write() here, just attributes().

Looks like you don't need the `attributes_for_write()` here, just `attributes()`.
const VArray<float> vgroup_weights =
LukasTonne marked this conversation as resolved Outdated
Falk David commented 2024-01-19 11:06:04 +01:00
Outdated
Review
Copy Link

const

`const`