blender
/
blender
136
417
Fork 600
Code Issues 6.3k Pull Requests 775 Projects 19 Wiki Activity

Brush Assets: Support adding shortcut to asset shelf items #117861

Merged
Hans Goudey merged 15 commits from HooglyBoogly/blender:brush-assets-shortcut into brush-assets-project 2024-02-07 19:02:47 +01:00
Conversation 0 Commits 15 Files Changed 10 +7 -4
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a2305229cb - Show all commits

11
source/blender/editors/asset/intern/asset_shelf_asset_view.cc
View File

@ -209,10 +209,13 @@ void AssetViewItem::build_grid_tile(uiLayout &layout) const
{
const AssetView &asset_view = reinterpret_cast<const AssetView &>(this->get_view());
const AssetShelfType &shelf_type = *asset_view.shelf_.type;
wmOperatorType *ot = WM_operatortype_find(shelf_type.activate_operator.c_str(), false);
PointerRNA op_props;
WM_operator_properties_create_ptr(&op_props, ot);
asset::operator_asset_reference_props_set(*handle_get_representation(&asset_), op_props);
wmOperatorType *ot = WM_operatortype_find(shelf_type.activate_operator.c_str(), true);
PointerRNA op_props = PointerRNA_NULL;
HooglyBoogly marked this conversation as resolved Outdated
Brecht Van Lommel commented 2024-02-05 19:03:59 +01:00
Outdated
Review
Copy Link

This function does not check if ot is null (but WM_operator_properties_create does check).

This function does not check if `ot` is null (but `WM_operator_properties_create` does check).
if (ot) {
WM_operator_properties_create_ptr(&op_props, ot);
asset::operator_asset_reference_props_set(*handle_get_representation(&asset_), op_props);
}
ui::PreviewGridItem::build_grid_tile_button(layout, ot, op_props);
}