blender
/
blender
134
424
Fork 606
Code Issues 6.4k Pull Requests 774 Projects 19 Wiki Activity

LineArt: conversion code from v2 to v3 #118791

Merged
Falk David merged 4 commits from ChengduLittleA/blender:lineart-conversion into main 2024-02-29 16:02:54 +01:00
Conversation 1 Commits 4 Files Changed 7 +2 -4
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 28fc1822b0 - Show all commits

6
source/blender/gpencil_modifiers_legacy/intern/lineart/lineart_shadow.cc
View File

@ -27,8 +27,6 @@
#include "MEM_guardedalloc.h"
using namespace blender::bke::greasepencil::convert;
/* Shadow loading etc. ================== */
ChengduLittleA marked this conversation as resolved Outdated
Falk David commented 2024-02-29 15:27:19 +01:00
Outdated
Review
Copy Link

Just use bke::greasepencil::convert::lineart_wrap_v3 instead of using the namespace in all of the file.

Just use `bke::greasepencil::convert::lineart_wrap_v3` instead of using the namespace in all of the file.
👍 1
LineartElementLinkNode *lineart_find_matching_eln(ListBase *shadow_elns, int obindex)
@ -1304,7 +1302,7 @@ bool lineart_main_try_generate_shadow(Depsgraph *depsgraph,
{
bool ret = false;
GreasePencilLineartModifierData lmd;
lineart_wrap_v3(lmd_legacy, &lmd);
blender::bke::greasepencil::convert::lineart_wrap_v3(lmd_legacy, &lmd);
ret = lineart_main_try_generate_shadow_v3(depsgraph,
scene,
original_ld,
@ -1314,7 +1312,7 @@ bool lineart_main_try_generate_shadow(Depsgraph *depsgraph,
r_eeln,
r_calculated_edges_eln_list,
r_shadow_ld_if_reproject);
lineart_unwrap_v3(lmd_legacy, &lmd);
blender::bke::greasepencil::convert::lineart_unwrap_v3(lmd_legacy, &lmd);
return ret;
}