blender
/
blender
134
424
Fork 606
Code Issues 6.3k Pull Requests 773 Projects 19 Wiki Activity

Anim: Detailed report if no keyframes have been inserted #119201

Merged
Christoph Lendenfeld merged 13 commits from ChrisLend/blender:return_keying_result into main 2024-04-09 09:39:25 +02:00
Conversation 2 Commits 13 Files Changed 4 +2 -2
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b9cbaafa47 - Show all commits

2
source/blender/animrig/intern/keyframing.cc
View File

@ -135,7 +135,7 @@ void CombinedKeyingResult::generate_reports(ReportList *reports)
}
if (has_reported_error) {
BKE_reportf(reports, RPT_ERROR, "%s", error.c_str());
BKE_report(reports, RPT_ERROR, error.c_str());
Sybren A. Stüvel commented 2024-03-25 10:00:52 +01:00
Outdated
Review
Copy Link

BKE_report(reports, RPT_ERROR, error.c_str());

`BKE_report(reports, RPT_ERROR, error.c_str());`
👍 1
}
else {
BKE_report(reports, RPT_WARNING, "Encountered unhandled error during keyframing");

2
source/blender/editors/animation/keyframing.cc
View File

@ -341,7 +341,7 @@ static int insert_key(bContext *C, wmOperator *op)
}
if (BLI_listbase_is_empty(&selection)) {
BKE_reportf(op->reports, RPT_WARNING, "Nothing selected to keyframe");
BKE_reportf(op->reports, RPT_WARNING, "Nothing selected to key");
Sybren A. Stüvel commented 2024-03-25 10:02:07 +01:00
Outdated
Review
Copy Link

In the rest of this PR "keyframe" is only used as a noun. Maybe "Nothing selected to key" is better?

In the rest of this PR "keyframe" is only used as a noun. Maybe "Nothing selected to key" is better?
👍 1
BLI_freelistN(&selection);
return OPERATOR_CANCELLED;
}