blender
/
blender
136
411
Fork 595
Code Issues 6.3k Pull Requests 775 Projects 19 Wiki Activity

Anim: run bezier handle calculation in parallel #119388

Merged
Christoph Lendenfeld merged 21 commits from ChrisLend/blender:thread_recalc_handles into main 2024-05-07 10:43:03 +02:00
Conversation 3 Commits 21 Files Changed 1 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 97097c0653 - Show all commits

2
source/blender/blenkernel/intern/fcurve.cc
View File

@ -1239,7 +1239,7 @@ void BKE_fcurve_handles_recalc_ex(FCurve *fcu, eBezTriple_Flag handle_sel_flag)
const bool cycle = BKE_fcurve_is_cyclic(fcu) && BEZT_IS_AUTOH(first) && BEZT_IS_AUTOH(last);
blender::IndexRange bezt_range(0, fcu->totvert);
blender::threading::parallel_for(bezt_range, 128, [&](const blender::IndexRange range) {
blender::threading::parallel_for(bezt_range, 512, [&](const blender::IndexRange range) {
for (const int i : range) {
BezTriple *bezt = &fcu->bezt[i];
Hans Goudey commented 2024-03-28 17:01:30 +01:00
Outdated
Review
Copy Link

How about pulling the special handling for the first and last keyframes out of the parallel loop, and skipping those two indices? bezt_range.drop_front(1).drop_back(1)

How about pulling the special handling for the first and last keyframes out of the parallel loop, and skipping those two indices? `bezt_range.drop_front(1).drop_back(1)`
Christoph Lendenfeld commented 2024-04-02 10:51:21 +02:00
Outdated
Review
Copy Link

To do that without duplicating the code within the loop I'd need to extract the logic into a function. Should I do this within this PR?

To do that without duplicating the code within the loop I'd need to extract the logic into a function. Should I do this within this PR?
Hans Goudey commented 2024-04-02 13:50:50 +02:00
Outdated
Review
Copy Link

Definitely not a big deal either way, it could wait if you preferred!

Definitely not a big deal either way, it could wait if you preferred!
BezTriple *prev = nullptr;