blender
/
blender
134
421
Fork 604
Code Issues 6.4k Pull Requests 769 Projects 19 Wiki Activity

Sculpt: Add polyline hide operator #119483

Merged
Hans Goudey merged 17 commits from Sean-Kim/blender:polyline-hide into main 2024-04-29 14:04:28 +02:00
Conversation 32 Commits 17 Files Changed 15 +4 -4
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c8213169fe - Show all commits

3
source/blender/editors/sculpt_paint/sculpt_intern.hh
View File

@ -1667,8 +1667,7 @@ enum ShapeType {
Box = 0,
Sean-Kim marked this conversation as resolved Outdated
Hans Goudey commented 2024-04-15 16:51:54 +02:00
Outdated
Review
Copy Link

I think the current name is fine, at least it's not worth adding a TODO here

I think the current name is fine, at least it's not worth adding a TODO here
/* In the context of a sculpt gesture, both lasso and polyline modal
* operators are handled as the same general shape.
* TODO: Rename to polygon? */
* operators are handled as the same general shape. */
Lasso = 1,
Line = 2,
};

5
source/blender/windowmanager/intern/wm_gesture_ops.cc
View File

@ -37,6 +37,7 @@
#include "RNA_access.hh"
using blender::Array;
using blender::float2;
using blender::int2;
/* -------------------------------------------------------------------- */
@ -809,8 +810,8 @@ int WM_gesture_polyline_modal(bContext *C, wmOperator *op, const wmEvent *event)
break;
}
Sean-Kim marked this conversation as resolved
Hans Goudey commented 2024-04-15 16:56:49 +02:00
Review
Copy Link

const float2 cur(cur_x, cur_y);
same with orig

`const float2 cur(cur_x, cur_y);` same with `orig`
const float cur[2] = {float(cur_x), float(cur_y)};
const float orig[2] = {float(border[0][0]), float(border[0][1])};
const float2 cur(cur_x, cur_y);
const float2 orig(border[0][0], border[0][1]);
const float dist = len_v2v2(cur, orig);