blender
/
blender
135
420
Fork 601
Code Issues 6.3k Pull Requests 767 Projects 19 Wiki Activity

EEVEE-Next: Jittered Soft Shadows #119753

Closed
Miguel Pozo wants to merge 46 commits from pragma37/blender:pull-eevee-jittered-shoft-shadows into main
pull from: pragma37/blender:pull-eevee-jittered-shoft-shadows
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 6 Commits 46 Files Changed 22 +8 -2
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fc9d6e0d97 - Show all commits

10
source/blender/makesrna/intern/rna_light.cc
View File

@ -317,14 +317,20 @@ static void rna_def_light_shadow(StructRNA *srna, bool sun)
prop = RNA_def_property(srna, "use_shadow_jittering", PROP_BOOLEAN, PROP_NONE);
RNA_def_property_boolean_sdna(prop, nullptr, "mode", LA_SHADOW_JITTER);
RNA_def_property_ui_text(prop, "Shadow Jittering", "Shadow Jittering (TODO)");
RNA_def_property_ui_text(prop,
"Shadow Jittering",
"Enable jittered shoft shadows (Disabled in the Viewport unless "
"enabled in the Scene settings)");
RNA_def_property_override_flag(prop, PROPOVERRIDE_OVERRIDABLE_LIBRARY);
RNA_def_property_update(prop, 0, "rna_Light_update");
prop = RNA_def_property(srna, "shadow_jitter_overblur", PROP_FLOAT, PROP_FACTOR);
RNA_def_property_range(prop, 0.0f, 1.0);
RNA_def_property_ui_range(prop, 0.0f, 1.0f, 0.1f, 2);
RNA_def_property_ui_text(prop, "Shadow Jitter Overblur", "Shadow Jitter Overblur (TODO)");
RNA_def_property_ui_text(
prop,
"Shadow Jitter Overblur",
"Apply shadow tracing to each jittered sample to reduce under-sampling artifacts");
RNA_def_property_override_flag(prop, PROPOVERRIDE_OVERRIDABLE_LIBRARY);
pragma37 marked this conversation as resolved Outdated
Clément Foucault commented 2024-04-19 22:03:27 +02:00
Outdated
Review
Copy Link

Should be PROP_PERCENTAGE.

Should be `PROP_PERCENTAGE`.
Miguel Pozo commented 2024-04-22 16:00:50 +02:00
Outdated
Review
Copy Link

Done, but I can't say I like it.

Done, but I can't say I like it.
RNA_def_property_update(prop, 0, "rna_Light_update");
pragma37 marked this conversation as resolved Outdated
Clément Foucault commented 2024-04-19 21:59:40 +02:00
Outdated
Review
Copy Link

Nitpick: It might be copied from somewhere else, but 1.0 is missing a f.

Nitpick: It might be copied from somewhere else, but `1.0` is missing a `f`.
pragma37 marked this conversation as resolved Outdated
Clément Foucault commented 2024-04-19 22:03:28 +02:00
Outdated
Review
Copy Link

UI range (soft range) should be similar to the DOF overblur. 20% soft max sounds good.

UI range (soft range) should be similar to the DOF overblur. `20%` soft max sounds good.