blender
/
blender
136
411
Fork 595
Code Issues 6.3k Pull Requests 771 Projects 19 Wiki Activity

Cleanup: Remove BLI_array macros in editmesh_knife #119976

Merged
Jesse Yurkovich merged 2 commits from deadpin/blender:cleanup-array-knife into main 2024-03-29 01:52:08 +01:00
Conversation 1 Commits 2 Files Changed 1 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 95a4e7dca2 - Show all commits

2
source/blender/editors/mesh/editmesh_knife.cc
View File

@ -1881,7 +1881,7 @@ static int linehit_compare(const KnifeLineHit &lh1, const KnifeLineHit &lh2)
if (lh1.v > lh2.v) {
return false;
}
return true;
return false;
deadpin marked this conversation as resolved Outdated
Germano Cavalcante commented 2024-03-27 20:20:34 +01:00
Outdated
Review
Copy Link

I think it has to return false here?
The reference says true if the first argument is less than the second (not equal).
https://en.cppreference.com/w/cpp/algorithm/sort

I think it has to return false here? The reference says `true` if the first argument is less than the second (not equal). https://en.cppreference.com/w/cpp/algorithm/sort
Jesse Yurkovich commented 2024-03-27 20:45:18 +01:00
Outdated
Review
Copy Link

Good catch!

Good catch!
}
/*