Checking the build log, seems it's not installing .zst
files for .fatbin
and hipfb
.
I had originally done that, but it makes the code more complex since we also need to adapt the path_exists checks. I guess we could add an optional "check_compressed" flag to path_exists and…
Should this be behind a cmake option? I could see during development you may want to skip the endless compress/decompress cycle
I think compression time is negligible compared to kernel…
Adding @Sergey as reviewer, mainly to check if he agrees this is ok to go into 4.2.
That was really quick. I only have one minor comment.
It maybe doesn't matter in practice, but I would prefer to fclose(in)
and fclose(out)
on these types of errors anyway. Maybe at some point it trips up a tool that checks for leaked file handles.
The issue is that combining blue noise and regular samples in a single render tends to be worse than not using blue noise at all.