Brecht Van Lommel brecht
  • Blender & Cycles developer

  • Joined on 2003-01-03
Brecht Van Lommel pushed to macos-libs at brecht/blender 2024-06-21 16:52:54 +02:00
2136407a3f Update hashes for MaterialX fix
Brecht Van Lommel created branch macos-libs in brecht/blender 2024-06-21 16:50:25 +02:00
Brecht Van Lommel pushed to macos-libs at brecht/blender 2024-06-21 16:50:25 +02:00
0ca47f801e update
f9624eb389 fixmaterialx
d398af8e3e updated libraries
029ce1c1c0 Merge branch 'blender-v4.2-release' into macos_armx64_libs
Compare 4 commits »
Brecht Van Lommel pushed to macos_x64_libs at blender/lib-macos_x64 2024-06-21 16:49:07 +02:00
5771ada6e8 Fix materialx config
Brecht Van Lommel pushed to macos_armx64 at blender/lib-macos_arm64 2024-06-21 16:48:36 +02:00
6620758908 Fix materialx config
Brecht Van Lommel suggested changes for blender/blender#123557 2024-06-21 16:43:14 +02:00
Cycles: Compress GPU kernels to reduce file size

Checking the build log, seems it's not installing .zst files for .fatbin and hipfb.

Brecht Van Lommel commented on pull request blender/blender#123557 2024-06-21 16:28:57 +02:00
Cycles: Compress GPU kernels to reduce file size

I had originally done that, but it makes the code more complex since we also need to adapt the path_exists checks. I guess we could add an optional "check_compressed" flag to path_exists and…

Brecht Van Lommel commented on pull request blender/blender#123557 2024-06-21 15:53:46 +02:00
Cycles: Compress GPU kernels to reduce file size

Should this be behind a cmake option? I could see during development you may want to skip the endless compress/decompress cycle

I think compression time is negligible compared to kernel…

Brecht Van Lommel commented on pull request blender/blender#123557 2024-06-21 15:40:54 +02:00
Cycles: Compress GPU kernels to reduce file size

Adding @Sergey as reviewer, mainly to check if he agrees this is ok to go into 4.2.

Brecht Van Lommel suggested changes for blender/blender#123557 2024-06-21 15:39:37 +02:00
Cycles: Compress GPU kernels to reduce file size

That was really quick. I only have one minor comment.

Brecht Van Lommel commented on pull request blender/blender#123557 2024-06-21 15:39:36 +02:00
Cycles: Compress GPU kernels to reduce file size

It maybe doesn't matter in practice, but I would prefer to fclose(in) and fclose(out) on these types of errors anyway. Maybe at some point it trips up a tool that checks for leaked file handles.

Brecht Van Lommel commented on pull request blender/blender#123557 2024-06-21 15:34:00 +02:00
Cycles: Compress GPU kernels to reduce file size

@blender-bot package

Brecht Van Lommel commented on pull request blender/blender#118479 2024-06-21 15:13:42 +02:00
Cycles: Implement blue-noise dithered sampling

The issue is that combining blue noise and regular samples in a single render tends to be worse than not using blue noise at all.

Brecht Van Lommel pushed to fix-materialx at brecht/blender 2024-06-21 14:09:36 +02:00
b1ad153660 Build: Auto patch cmake config for stripping version from dylib
Brecht Van Lommel deleted branch fix-123528 from Alaska/blender 2024-06-21 14:07:11 +02:00
Brecht Van Lommel closed issue blender/blender#123528 2024-06-21 14:07:08 +02:00
Cycles: Incorrect denoising UI on NVIDIA GPU system with CPU viewport rendering
Brecht Van Lommel merged pull request blender/blender#123530 2024-06-21 14:07:04 +02:00
Fix #123528: Cycles backend denoiser choice did not match UI on NVIDIA
Brecht Van Lommel pushed to blender-v4.2-release at blender/blender 2024-06-21 14:07:04 +02:00
47158e1606 Fix #123528: Cycles viewport denoiser not using GPU for CPU render