Brecht Van Lommel brecht
  • Blender & Cycles developer

  • Joined on 2003-01-03
Brecht Van Lommel commented on pull request blender/blender#122871 2024-06-13 15:46:48 +02:00
UI: Support semi-modal text input while other UI stays interactive - use for search button in asset shelf popup

This check is redundant, it already early outs above.

Brecht Van Lommel commented on pull request blender/blender#122871 2024-06-13 15:46:47 +02:00
UI: Support semi-modal text input while other UI stays interactive - use for search button in asset shelf popup

This check is redundant, it already early outs above.

Brecht Van Lommel commented on pull request blender/blender#122871 2024-06-13 15:46:45 +02:00
UI: Support semi-modal text input while other UI stays interactive - use for search button in asset shelf popup

This comment should be above ui_handle_region_semi_modal_buttons, since that's also events for our own menu.

Brecht Van Lommel suggested changes for blender/blender#123177 2024-06-13 15:17:29 +02:00
Fix #74816: crash in Cycles light distribution due to integer overflow

I think this should be an error. Often it's better not to render than silently have some issue that might be difficult to debug.

Brecht Van Lommel suggested changes for blender/blender#123070 2024-06-13 12:47:50 +02:00
Fix #123044: Allow frame number -1 as a valid point cache frame

The -1 special value made sense to me to eliminate, since it doesn't affect the files written to disk as far as I can see.

Brecht Van Lommel commented on pull request blender/blender#123070 2024-06-13 12:47:49 +02:00
Fix #123044: Allow frame number -1 as a valid point cache frame

This check is for the info file, which is no longer 0.

Brecht Van Lommel commented on pull request blender/blender#123070 2024-06-13 12:47:47 +02:00
Fix #123044: Allow frame number -1 as a valid point cache frame

This comment is outdated.

Brecht Van Lommel commented on pull request blender/blender#122894 2024-06-13 12:30:47 +02:00
Fix #69898: Animated EXR have wrong node outputs

Yes, that was my idea, to always write animated and driven passes and layers.

Brecht Van Lommel commented on issue blender/blender#122779 2024-06-12 21:24:47 +02:00
Illegal address error with OptiX OSL with specific materials

I was able to reproduce this with the 555.52 beta driver on Linux.

It appears to be crashing in osl_allocate_weighted_closure_component with a null weight. But after checking for that it…

Brecht Van Lommel commented on pull request blender/blender#122894 2024-06-12 20:37:41 +02:00
Fix #69898: Animated EXR have wrong node outputs

Ok. Maybe we should write layers and passes that are all zero. With any compression the resulting EXR file size should not be affected much.

The way the render API works it's not trivial to…

Brecht Van Lommel closed issue blender/blender#123080 2024-06-12 20:27:31 +02:00
extensions system looking for incorrect extension folder.
Brecht Van Lommel commented on issue blender/blender#123080 2024-06-12 20:27:27 +02:00
extensions system looking for incorrect extension folder.

I think this is was an intentional change.

Particularly: https://docs.blender.org/manual/en/4.2/advanced/extensions/addons.html#extensions-and-namespace

The legacy add-ons would use their…

Brecht Van Lommel pushed to main at blender/blender 2024-06-12 20:07:54 +02:00
ed66bd4245 Merge branch 'blender-v4.2-release'
1d45bb705e Fix: EEVEE assert rendering transparent pass
87dae7d800 Build: Clean up oneAPI cmake messages
c3dcad64c7 Fix #122989: Enabling installed legacy add-on fails without scripts folder
3a7a9c60df Cleanup: Compiler warning building without OIDN
Compare 7 commits »
Brecht Van Lommel closed issue blender/blender#122989 2024-06-12 20:07:52 +02:00
error installing legacy addon if scripts/addons does not exist
Brecht Van Lommel closed issue blender/blender#121819 2024-06-12 20:07:48 +02:00
OCIO error in gpu.shader when using a custom OCIO configuration that uses ocio_profile_version: 2
Brecht Van Lommel pushed to blender-v4.2-release at blender/blender 2024-06-12 20:07:03 +02:00
1d45bb705e Fix: EEVEE assert rendering transparent pass
Brecht Van Lommel commented on pull request blender/blender#122894 2024-06-12 20:04:55 +02:00
Fix #69898: Animated EXR have wrong node outputs

One potential solution would be to change the render animation code to put placeholders for layers and passes in the EXR files, so that they exist in all frames. Maybe using zero size channels (if…

Brecht Van Lommel closed issue blender/blender#122574 2024-06-12 19:59:57 +02:00
Viewlayer's animated render visibility corrupts layer association in EXR Multilayer export
Brecht Van Lommel commented on issue blender/blender#122574 2024-06-12 19:59:53 +02:00
Viewlayer's animated render visibility corrupts layer association in EXR Multilayer export

I think this is a duplicate of #69898 that @OmarEmaraDev and @Sergey were looking into.

Brecht Van Lommel commented on issue blender/blender#123080 2024-06-12 19:56:13 +02:00
extensions system looking for incorrect extension folder.

Yes, I don't think it should assume __name__ has any relation to folder names. __file__ seems more suitable for that purpose.