Hm, even if I include the esnapDir namespace when referencing the enums, I get errors and the code does not compile. The bitwise operators still don't work, telling me "no operator matches these…
Changing from typedef enum eSnapDir to enum struct eSpanDir : int8_t means "variable eSnapDir is not a type name" anymore. It creates an error on line 322 of that file.
Doing this means that the declaration in TransSnap breaks; even if I change the type there from eSnapDir to int8_t this breaks code where I use bitwise operators on tsnap.direction. How should…
I see what you mean by having to add
do_snap_timeline. Eeeh it is and isn't inevitable - What I would do, is to have say functionquery_snap_sources_timeline()and `query_snap_sources_preview…
When I remove it I get errors when trying to perform bitwise operations on the enum because of type safety features added with C++. I think it's necessary, but tell me if you know a different way…
Not really an issue, just in my opinion it would be much nicer to have one place for this data - it would allow for nicer function naming as well. Maybe I wasn't as verbose in review, but that…
Testing the patch now, it seems pretty good overall. One thing that I don't quite understand how it should work is "Other strips" option in snapping menu. I would think, that this should be…