John Kiril Swenson eliphaz
  • Joined on 2021-06-11
John Kiril Swenson commented on pull request blender/blender#124333 2024-08-09 18:33:00 +02:00
VSE: Connected Strips

@fsiddi just giving a nudge to let you know that all the feedback & bugs should be addressed now if you'd like to kick up another package build for testing!

John Kiril Swenson commented on pull request blender/blender#124333 2024-08-09 18:24:35 +02:00
VSE: Connected Strips

This relates to what is the main purpose and ambition of implementing a connecting strips functionality:

  1. To preserve sync between strips?
  2. To group the strips into one object? Not…
John Kiril Swenson commented on pull request blender/blender#124333 2024-08-09 01:05:42 +02:00
VSE: Connected Strips

So, has it been tested to limit auto-select the linked-to strips during the transform operations? Ex. hit "g" and all linked-to strips will get the outline while transforming, and after a…

John Kiril Swenson pushed to vse-linked-strips at eliphaz/blender 2024-08-09 00:48:53 +02:00
d328f8c88b Further fixes and changes
John Kiril Swenson pushed to vse-linked-strips at eliphaz/blender 2024-08-09 00:25:41 +02:00
842508857e Address further feedback
John Kiril Swenson commented on pull request blender/blender#124333 2024-08-08 11:59:51 +02:00
VSE: Connected Strips

Tweaking was introduced in 4.2. It's expected to work as you describe for RCS. Fair enough! Will get that working. What footage are you using to test the feature? I can provide you with…

John Kiril Swenson commented on pull request blender/blender#124333 2024-08-07 23:07:01 +02:00
VSE: Connected Strips
  1. "tweaking" handles (with RCS) does not take into account connected strips
  2. try retiming a connected audio/video (leads to unexpected behaviour)
  3. consider adding a Ctrl+Alt+L as a…
John Kiril Swenson deleted branch cleanup-retiming-selection from eliphaz/blender 2024-08-07 15:05:56 +02:00
John Kiril Swenson pushed to vse-linked-strips at eliphaz/blender 2024-08-07 14:01:08 +02:00
70fe3f53f8 Fix up remaining code review
John Kiril Swenson pushed to vse-linked-strips at eliphaz/blender 2024-08-07 13:58:48 +02:00
0534552638 Address code review
John Kiril Swenson commented on pull request blender/blender#124333 2024-08-07 13:16:47 +02:00
VSE: Connected Strips

Good point, it is a bit unwieldy in its current form. I just realized that there's a SEQ_ALLSEL macro and replaced the code with that to make it a bit clearer and more future-proof (updating the…

John Kiril Swenson commented on pull request blender/blender#124333 2024-08-07 13:16:20 +02:00
VSE: Connected Strips

I was thinking it could be used for a small indicator to let you know how "out of sync" your connected strips are (in case you want to nudge either audio or video slightly from their original…

John Kiril Swenson pushed to vse-linked-strips at eliphaz/blender 2024-08-06 23:39:57 +02:00
7f64748f09 Finish implementation, ready for review
John Kiril Swenson pushed to vse-linked-strips at eliphaz/blender 2024-08-01 06:47:13 +02:00
b01ed7bb94 Fix small bug in SEQ_disconnect
John Kiril Swenson pushed to vse-linked-strips at eliphaz/blender 2024-07-30 05:20:13 +02:00
f6c84bbf4c Merge branch 'main' into vse-linked-strips
6bc705e3e6 Use SeqConnection struct, add strip_connect.cc
edf298b505 Cleanup: Formatting
99af19932e Cleanup: spelling in comments
d8c2301ee8 Cleanup: use const arguments
Compare 129 commits »
John Kiril Swenson pushed to vse-linked-strips at eliphaz/blender 2024-07-29 06:34:49 +02:00
814af403bc Give added strips connections by default
John Kiril Swenson pushed to vse-linked-strips at eliphaz/blender 2024-07-29 03:28:09 +02:00
8c840d8fe4 Finish merge
John Kiril Swenson created pull request blender/blender#125468 2024-07-26 04:27:24 +02:00
VSE: Cleanup retiming selection code
John Kiril Swenson created branch cleanup-retiming-selection in eliphaz/blender 2024-07-26 04:26:57 +02:00
John Kiril Swenson pushed to cleanup-retiming-selection at eliphaz/blender 2024-07-26 04:26:57 +02:00
fa86fd21ab VSE: Cleanup retiming selection code