[TODO] improve x3d import/export: review changes on https://github.com/Web3DConsortium/BlenderX3DSupport #21

New Issue

Cedric Steiert · 2024-09-10T03:15:32+02:00

Cedric Steiert commented

2024-09-10 03:15:32 +02:00

Compare current version to the changes made on https://github.com/Web3DConsortium/BlenderX3DSupport and its forks and add/fix features in this repo here if applicable.

Cedric Steiert added the

enhancement

help wanted

task

labels 2024-09-10 03:15:33 +02:00

Vincent Marchetti commented

2024-09-10 12:40:54 +02:00

I am one of the developers and administrators of the Web3D Consortium effort at https://github.com/Web3DConsortium/BlenderX3DSupport . I am working exactly on identifying what in the Consortium's work is ready to be merged into the io_scene_x3d extension. My plan was to prepare a new Github repo forked from the https://projects.blender.org/extensions/io_scene_x3d . If I did so, would il be possible to, when appropriate, submit a pull request for review and merging from a github branch, or is there a more appropriate mechanism for submitting changes?

Cedric Steiert commented

2024-09-10 13:51:16 +02:00

Hi Vincent, thanks for reaching out from https://github.com/Web3DConsortium/BlenderX3DSupport/issues/10.

I am working exactly on identifying what in the Consortium's work is ready to be merged into the io_scene_x3d extension.

Happy to hear that.
I myself neither have to knowledge nor the time for implementing crazy fancy new IO features like you guys do, as i'm a junior software developer and student in the field of game engineering. Just trying to keep the boat afloat (in terms of fixing bugs, adding minor features, ensuring it works with coming blender versions for basic IO, merging changes made by community), because no one else seemed to do so.

Main aspects here to look out for when attempting in bringing in your changes:

It needs to work for blender 4.2+; older versions of blender won't get the extensions updates, so more often than not a lot of redundant legacy api code can be removed. That's actually the point why i reached out, as i was thinking about maybe slimming down the current codebase mid/end next year for better maintainability, depending on time constraints; then the two projects could potentially move far away from each other as the differences may get too high.
If the effort needed to update to blender 4.2+ would be too high, i'll add your repo in the documentation of this extension, so users can have the features at least in an older blender version. Just let me know.
Current state of import/export should remain intact/functional, as Campbell said "as long as it [Web3D extension] remains working for basic IO."
features should be documented: for users in form of a readme/wiki entry and for developers e.g. with docstrings and appropriate code comments

Github repo forked from the https://projects.blender.org/extensions/io_scene_x3d . If I did so, would il be possible to, when appropriate, submit a pull request for review and merging from a github branch, or is there a more appropriate mechanism for submitting changes?

Sure, i'd be glad to see new features and improved old ones. Where the code is located doesn't matter (a local merge works nontheless), so a github fork is fine. Anyways i'll add you as a contributor to the extension, giving you full read/write access to this repo. If the others wish as well, just drop a comment.

What changes are we talking about? If i sumarize the comment from John in https://github.com/Web3DConsortium/BlenderX3DSupport/issues/10 correctly, that would probably be:

addition of x3dv/x3dj import/export (or shall that remain a seperate addon?)
addition of HAnim parsing for x3d
changes in vrml import
some fixes
The main goals from the readme don't seem to have happened yet.

Hi Vincent, thanks for reaching out from https://github.com/Web3DConsortium/BlenderX3DSupport/issues/10. > I am working exactly on identifying what in the Consortium's work is ready to be merged into the io_scene_x3d extension. Happy to hear that. I myself neither have to knowledge nor the time for implementing crazy fancy new IO features like you guys do, as i'm a junior software developer and student in the field of game engineering. Just trying to keep the boat afloat (in terms of fixing bugs, adding minor features, ensuring it works with coming blender versions for basic IO, merging changes made by community), because no one else seemed to do so. Main aspects here to look out for when attempting in bringing in your changes: - It needs to work for blender 4.2+; older versions of blender won't get the extensions updates, so more often than not a lot of redundant legacy api code can be removed. That's actually the point why i reached out, as i was thinking about maybe slimming down the current codebase mid/end next year for better maintainability, depending on time constraints; then the two projects could potentially move far away from each other as the differences may get too high. - If the effort needed to update to blender 4.2+ would be too high, i'll add your repo in the documentation of this extension, so users can have the features at least in an older blender version. Just let me know. - Current state of import/export should remain intact/functional, as Campbell said "as long as it [Web3D extension] remains working for basic IO." - features should be documented: for users in form of a readme/wiki entry and for developers e.g. with docstrings and appropriate code comments > Github repo forked from the https://projects.blender.org/extensions/io_scene_x3d . If I did so, would il be possible to, when appropriate, submit a pull request for review and merging from a github branch, or is there a more appropriate mechanism for submitting changes? Sure, i'd be glad to see new features and improved old ones. Where the code is located doesn't matter (a local merge works nontheless), so a github fork is fine. Anyways i'll add you as a contributor to the extension, giving you full read/write access to this repo. If the others wish as well, just drop a comment. What changes are we talking about? If i sumarize the comment from John in https://github.com/Web3DConsortium/BlenderX3DSupport/issues/10 correctly, that would probably be: - addition of x3dv/x3dj import/export (or shall that remain a seperate addon?) - addition of HAnim parsing for x3d - changes in vrml import - some fixes - The main goals from the readme don't seem to have happened yet.

Sign in to join this conversation.