extensions/io_scene_x3d
2
1
Fork 4
Code Issues 14 Pull Requests 2 Projects Releases Wiki Activity

X3D/WRL Import: TextStyle - Font family, style not getting parsed #31

New Issue
Closed
opened 2024-10-25 21:47:55 +02:00 by Cedric Steiert · 2 comments
Cedric Steiert commented 2024-10-25 21:47:55 +02:00
Collaborator
Copy Link

Text importer:

source/import_x3d.py Line 3181 in e68efebfb1
def importText(geom, ancestry):

The current implementation does not take Font family (e.g. SANS), style (e.g. BOLD), justify (e.g. MIDDLE -> horizontal alignment), spacing (e.g. 1 -> line height/spacing) into account. Only size gets parsed atm.

justify and spacing should be easy to add. For the font family and style we'd have to lookup the system font files and find a matching one. For the implementation make sure we don't get "stuck" here, as import should work always regardless.

Attached some wrl files for testing.

Text importer: https://projects.blender.org/extensions/io_scene_x3d/src/commit/e68efebfb1c83493afe571b482a4469a20a3560b/source/import_x3d.py#L3181 The current implementation does not take Font family (e.g. SANS), style (e.g. BOLD), justify (e.g. MIDDLE -> horizontal alignment), spacing (e.g. 1 -> line height/spacing) into account. Only size gets parsed atm. justify and spacing should be easy to add. For the font family and style we'd have to lookup the system font files and find a matching one. For the implementation make sure we don't get "stuck" here, as import should work always regardless. Attached some wrl files for testing.
FontStyle_Sans.wrl
910 B
FontStyle_Typewriter.wrl
916 B
FontStyle_Typewriter_italic_size5.wrl
918 B
FontStyle_Typewriter_italic_space5.wrl
918 B
FontStyle_Typewriter_italic.wrl
918 B
Cedric Steiert added the
enhancement
task
 labels 2024-10-25 21:47:55 +02:00
Cedric Steiert changed title from X3D/WRL Import: TextStyle - Font family, style, justify, spacing not getting parsed to X3D/WRL Import: TextStyle - Font family, style not getting parsed 2024-11-04 12:50:17 +01:00
Cedric Steiert commented 2024-11-04 12:51:08 +01:00
Author
Collaborator
Copy Link

justify and spacing is now getting parsed an applied. Style (bold/italic) and font family is a bit more tricky and thus still a todo.

justify and spacing is now getting parsed an applied. Style (bold/italic) and font family is a bit more tricky and thus still a todo.
Cedric Steiert commented 2024-11-06 20:13:25 +01:00
Author
Collaborator
Copy Link

Attached file now imports with all properties set and font family inclusive variants set:
grafik

Attached file now imports with all properties set and font family inclusive variants set: ![grafik](/attachments/7bd42c06-d2d5-47f4-ad4d-f7e9f1ad8042)
grafik.png
556 KiB
FontStyle_Arial_italic.wrl
913 B
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

Something is not working

  
confirmed

The issue is confirmed.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
High

Priority high: This issue should be worked on soon, as it breaks things drastically

  
known issue

A known technical limitation. It may get fixed eventually, but no support expected.

  
Low

Priority low: Could be worked on, but is of no need

  
Normal

Priority normal: Not a high issue, still relevant

  
not a task

just some content

  
question

More information is needed

  
task

Tasks that should be worked on

  
v2.4

Tasks included for 2.4 release

  
wontfix

This won't be fixed

No Label
bug
confirmed
duplicate
enhancement
help wanted
High
known issue
Low
Normal
not a task
question
task
v2.4
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: extensions/io_scene_x3d#31
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?