Lukasz Czyz glukoz
  • Joined on 2016-07-07
Lukasz Czyz commented on pull request blender/blender#114545 2024-09-30 19:52:49 +02:00
The SLIM UV unwrap algorithm implementation for Blender 4.x

Now I would like to focus on updating the Minimize Stretch operator so it uses SLIM behind the scenes. Thus no time for updating documentation.

Lukasz Czyz commented on pull request blender/blender#114545 2024-09-21 15:49:21 +02:00
The SLIM UV unwrap algorithm implementation for Blender 4.x

Great news! Thank you all for testing and reviewing this PR :)

Lukasz Czyz commented on pull request blender/blender#114545 2024-09-18 09:08:41 +02:00
The SLIM UV unwrap algorithm implementation for Blender 4.x

A kind reminder.

Lukasz Czyz pushed to uv_unwrapping_slim_algorithm_v5_update at glukoz/blender 2024-09-13 18:40:36 +02:00
cf689c2c5b make format.
fee676bc74 Add uvedit_live_unwrap_timer check.
8439131e39 uv_matrices - layout fix.
Compare 3 commits »
Lukasz Czyz commented on pull request blender/blender#114545 2024-09-13 18:00:57 +02:00
The SLIM UV unwrap algorithm implementation for Blender 4.x

After a closer look at the code: it turns out Eigen excepts a column-major format of input. It means that the given arrays are initialized in the following layout:

`[ all x coordinates, 0 .. n…

Lukasz Czyz commented on pull request blender/blender#114545 2024-09-13 15:03:16 +02:00
The SLIM UV unwrap algorithm implementation for Blender 4.x

Can we finish this review in the nearest feature? I think there is not much work left here.

Lukasz Czyz commented on pull request blender/blender#114545 2024-09-06 15:21:47 +02:00
The SLIM UV unwrap algorithm implementation for Blender 4.x

Using a linearized form is safer because we have full control over the data layout. The proper layout is essential when the arrays are passed to initialize Eigen Map objects.

Lukasz Czyz commented on pull request blender/blender#114545 2024-09-06 15:19:49 +02:00
The SLIM UV unwrap algorithm implementation for Blender 4.x

There are a lot of places in the code which assumes that the input mesh does not contain degenerate triangles (because that's an assumption of the original SLIM implementation in lib IGL). In…

Lukasz Czyz commented on pull request blender/blender#114545 2024-09-06 15:17:51 +02:00
The SLIM UV unwrap algorithm implementation for Blender 4.x

There are a lot of places in the code which assumes that the input mesh does not contain degenerate triangles (because that's an assumption of the original SLIM implementation in lib IGL). In…

Lukasz Czyz commented on pull request blender/blender#114545 2024-09-06 15:17:28 +02:00
The SLIM UV unwrap algorithm implementation for Blender 4.x

There are a lot of places in the code which assumes that the input mesh does not contain degenerate triangles (because that's an assumption of the original SLIM implementation in lib IGL). In…

Lukasz Czyz pushed to uv_unwrapping_slim_algorithm_v5_update at glukoz/blender 2024-09-06 15:05:14 +02:00
2b4ef2e91e SLIM - variables renaming.
Lukasz Czyz commented on pull request blender/blender#114545 2024-09-06 14:28:12 +02:00
The SLIM UV unwrap algorithm implementation for Blender 4.x

Yes, it was an arbitrary number chosen by Aurel. My understanding is it should be 'not too big, not very small'. I think giving access to this setting to the user is not justified as it is the…

Lukasz Czyz commented on pull request blender/blender#114545 2024-09-06 14:25:02 +02:00
The SLIM UV unwrap algorithm implementation for Blender 4.x

@ideasman42 - what do you think?

Lukasz Czyz pushed tag v3.6.15 to glukoz/blender 2024-09-06 14:22:35 +02:00
Lukasz Czyz pushed tag v4.2.1 to glukoz/blender 2024-09-06 14:22:35 +02:00
Lukasz Czyz pushed to uv_unwrapping_slim_algorithm_v5_update at glukoz/blender 2024-09-06 14:22:32 +02:00
3493e17259 SLIM - remove weights memeber from BMUVOffsets.
6d5f920e02 SLIM - remove DNA default macros.
cc77737fd4 SLIM - do not use p_chart_collapse_doubles.
e46b156cb2 SLIM - further review fixes.
9905c5a56f Review fixes.
Compare 1551 commits »
Lukasz Czyz commented on pull request blender/blender#114545 2024-09-01 23:40:22 +02:00
The SLIM UV unwrap algorithm implementation for Blender 4.x

In my opinion we should leave it as is for now and gather feedback from users - it's hard to predict whether this feature will be widely at all. My it's a module owner who should make the final…

Lukasz Czyz commented on pull request blender/blender#114545 2024-08-27 14:08:56 +02:00
The SLIM UV unwrap algorithm implementation for Blender 4.x

I think it makes most sense the mesh can define it's UV importance group, similar to vertex_group_active_index.

Sounds like an interesting idea but in which place in the UI could the user…

Lukasz Czyz commented on pull request blender/blender#114545 2024-08-27 13:55:55 +02:00
The SLIM UV unwrap algorithm implementation for Blender 4.x

This name was originally proposed by @brecht , check here: blender/blender#114545 (comment)

Lukasz Czyz commented on pull request blender/blender#114545 2024-08-17 12:49:39 +02:00
The SLIM UV unwrap algorithm implementation for Blender 4.x

Thank you for your input. I will introduce fixes after Campbell takes a look at the code (unfortunately I am not able to mark him in this message due to some reason)