Campbell Barton ideasman42
  • Australia
  • Joined on 2005-01-30
Campbell Barton suggested changes for blender/blender#129209 2024-10-18 12:31:04 +02:00
Fix: operators can have invalid utf-8 strings

Is there a simple test case to validate this?

Campbell Barton approved blender/blender#129018 2024-10-18 10:42:37 +02:00
make license: command to update the license file

Some additional notes, they're more personal preference though.

Campbell Barton commented on pull request blender/blender#129018 2024-10-18 10:42:36 +02:00
make license: command to update the license file

Not full sentences (some other comments here too).

Campbell Barton commented on pull request blender/blender#129018 2024-10-18 10:42:35 +02:00
make license: command to update the license file

When writing this I hand't noticed the convention you had of printing with exit(1), it might be better to follow that convention here too.

Campbell Barton commented on pull request blender/blender#129018 2024-10-18 10:42:34 +02:00
make license: command to update the license file

*picky* ... very much personal preference but I find the trailing \ end up being more trouble than they're worth.

Campbell Barton commented on pull request blender/blender#129018 2024-10-18 10:42:33 +02:00
make license: command to update the license file

*picky* I tend to perfer fh instead of f, short for FileHandle, this has the advantage of not being confused with f which is sometimes short for filename.

Campbell Barton commented on pull request blender/blender#129018 2024-10-18 10:42:31 +02:00
make license: command to update the license file

*picky* use space after License: ?

Campbell Barton closed pull request blender/blender#129191 2024-10-18 08:38:33 +02:00
PyAPI: support Python 3.13
Campbell Barton pushed to main at blender/blender 2024-10-18 08:36:42 +02:00
d9f38fca5f PyAPI: support Python 3.13
Campbell Barton closed issue blender/blender#123871 2024-10-18 08:36:40 +02:00
Blender fails to build against Python 3.13 due to use of various functions that have been moved to internal API
Campbell Barton commented on pull request blender/blender#129018 2024-10-18 07:40:38 +02:00
make license: command to update the license file

Generally LGTM although the string parsing was something I mentioned to Thomas to get things working.

This patch supports un-parsed mult-line strings which won't attempt to expand variables or…

Campbell Barton commented on pull request blender/blender#129191 2024-10-18 06:13:01 +02:00
PyAPI: support Python 3.13
Campbell Barton created pull request blender/blender#129191 2024-10-18 06:12:44 +02:00
PyAPI: support Python 3.13
Campbell Barton pushed to pr-py313-update at ideasman42/blender 2024-10-18 06:09:20 +02:00
9ccb7fffef Updates to support Python 3.13
Campbell Barton pushed to pr-py313-update at ideasman42/blender 2024-10-18 06:07:40 +02:00
f557b0071f Unbreak "make update" on the buildbot which uses Python 3.9
Compare 3 commits »
Campbell Barton created branch pr-py313-update in ideasman42/blender 2024-10-18 06:07:40 +02:00
Campbell Barton closed pull request blender/blender#129188 2024-10-18 04:14:33 +02:00
WIP Unbreak builtbot from Python 3.9 failure
Campbell Barton pushed to main at blender/blender 2024-10-18 04:10:09 +02:00
f557b0071f Unbreak "make update" on the buildbot which uses Python 3.9
Campbell Barton commented on pull request blender/blender#129188 2024-10-18 03:40:40 +02:00
WIP Unbreak builtbot from Python 3.9 failure
Campbell Barton created pull request blender/blender#129188 2024-10-18 03:40:17 +02:00
WIP Unbreak builtbot from Python 3.9 failure