Campbell Barton ideasman42
  • Australia
  • Joined on 2005-01-30
Campbell Barton commented on pull request blender/blender#129121 2024-10-17 07:43:06 +02:00
Fix: BMO_Assert when bmo_join_triangles_exec leaves triangles left over when using topology_influence

Regarding bm->totedge allocation, we could reduce the allocation to only store an array the size of edges which may be joined.

I'd suspect the benefit to calculating the array size and making…

Campbell Barton merged pull request blender/blender#129121 2024-10-17 07:24:25 +02:00
Fix: BMO_Assert when bmo_join_triangles_exec leaves triangles left over when using topology_influence
Campbell Barton pushed to main at blender/blender 2024-10-17 07:23:28 +02:00
da689835e8 Fix #129110: Join triangles can assert when topology influence is used
Campbell Barton closed issue blender/blender#129110 2024-10-17 07:23:26 +02:00
BMO_Assert when bmo_join_triangles_exec leaves triangles left over when using topology_influence
Campbell Barton pushed to pr-128899-update at ideasman42/blender 2024-10-17 06:58:10 +02:00
d713003e00 Fix massive amount of memleaks on exit in BPY
3e6565b9d7 Merge branch 'blender-v4.3-release'
e2862ed7ca Cleanup: rename variables handling modules loaded at startup
Compare 3 commits »
Campbell Barton pushed to main at blender/blender 2024-10-17 06:50:59 +02:00
3e6565b9d7 Merge branch 'blender-v4.3-release'
e2862ed7ca Cleanup: rename variables handling modules loaded at startup
Compare 2 commits »
Campbell Barton pushed to blender-v4.3-release at blender/blender 2024-10-17 06:48:01 +02:00
e2862ed7ca Cleanup: rename variables handling modules loaded at startup
Campbell Barton suggested changes for blender/blender#128899 2024-10-17 06:36:02 +02:00
Fix massive amount of memleaks on exit in BPY.

Overall this seems fine, I've made updates to the PR (!129138) which address the inline comments.

Campbell Barton commented on pull request blender/blender#128899 2024-10-17 06:36:01 +02:00
Fix massive amount of memleaks on exit in BPY.

Technically incorrect bpy should be bpy.utils ... although this will always be set in practice.

Campbell Barton commented on pull request blender/blender#128899 2024-10-17 06:36:00 +02:00
Fix massive amount of memleaks on exit in BPY.

Instead of having both addon_utils.disable_all(), bpy.utils.unregister_startup_scripts() called from different parts of the WM code, I'd rather have a single shutdown function defined in Python, then we can always add additional cleanup logic there instead of having to add awkward BPY_run_string_eval calls each time.

Campbell Barton commented on pull request blender/blender#128899 2024-10-17 06:35:59 +02:00
Fix massive amount of memleaks on exit in BPY.

Unused variable warning as the use is if 0 ed.

Campbell Barton commented on pull request blender/blender#128899 2024-10-17 06:35:57 +02:00
Fix massive amount of memleaks on exit in BPY.

Since this runs almost 6000 times, I was worried there might be unnecessary overhead as each call locks Python's GIL.

Campbell Barton commented on pull request blender/blender#128899 2024-10-17 06:35:56 +02:00
Fix massive amount of memleaks on exit in BPY.

Since the PR was made except Exception: was used, same for unregister.

Campbell Barton commented on pull request blender/blender#128899 2024-10-17 06:35:55 +02:00
Fix massive amount of memleaks on exit in BPY.

This is such a spesific function which we never want add-on authors to call, I think a _ prefixed name makes more sense ... it can be left out of "all" too.

Campbell Barton commented on pull request blender/blender#128899 2024-10-17 06:35:53 +02:00
Fix massive amount of memleaks on exit in BPY.

Actually scanning directories on exit isn't unnecessary,

Campbell Barton pushed to pr-128899-update at ideasman42/blender 2024-10-17 06:24:12 +02:00
48f0c6202b Fix massive amount of memleaks on exit in BPY
Campbell Barton created pull request blender/blender#129138 2024-10-17 06:23:13 +02:00
Fix massive amount of memleaks on exit in BPY
Campbell Barton pushed to main at blender/blender 2024-10-17 06:22:30 +02:00
8ed8613469 Merge branch 'blender-v4.3-release'
d9fe0bcfaf Cleanup: avoid 2x redundant lookups in BrushAssetShelf.poll
Compare 2 commits »