Campbell Barton ideasman42
  • Australia
  • Joined on 2005-01-30
Campbell Barton commented on pull request blender/blender#129018 2024-10-16 10:03:02 +02:00
make license: command to update the license file

set doesn't define a type.

Campbell Barton commented on pull request blender/blender#129018 2024-10-16 10:03:01 +02:00
make license: command to update the license file

match is now a Python keyword, while it can also be used as a variable it does highlight a confusingly depending on the editor. I tend to avoid it for this reason and use something a little more descriptive. set_fn_match or re_match e.g.

Campbell Barton commented on pull request blender/blender#129018 2024-10-16 10:02:59 +02:00
make license: command to update the license file

Function syntax seems unnecessary.

Campbell Barton commented on pull request blender/blender#129018 2024-10-16 10:02:58 +02:00
make license: command to update the license file

mypy --strict reports many errors, type info looks to be incorrect (set/dict mixup). Should be corrected before merging.

Campbell Barton commented on pull request blender/blender#129018 2024-10-16 10:02:57 +02:00
make license: command to update the license file

While somewhat personal taste r""" is useful for literal blocks like this to ensure any \ characters aren't interpreted as escape-chars (unless you this is what's intended).

Campbell Barton pushed to main at blender/blender 2024-10-16 08:04:48 +02:00
11dfa3297e Merge branch 'blender-v4.3-release'
ccb92947c5 Fix #129067: Transforming an edit-mesh crashes with cage editing
Compare 2 commits »
Campbell Barton closed issue blender/blender#129067 2024-10-16 08:04:46 +02:00
Crash when using Subdivision Modifier and Armature Modifier on a skinned mesh(v4.2.3LTS)
Campbell Barton pushed to blender-v4.3-release at blender/blender 2024-10-16 08:02:49 +02:00
ccb92947c5 Fix #129067: Transforming an edit-mesh crashes with cage editing
Campbell Barton commented on issue blender/blender#128346 2024-10-16 07:44:22 +02:00
Regression: outliner delay refreshing makes search results fail to display

@JacquesLucke, no action needed but CC'ing you as the issue was introduced in a63ac425d07533e602d285df4e1a13e8ec64c4cf.

Committed a workaround for the issue, attempting to split out outliner…

Campbell Barton closed pull request blender/blender#129089 2024-10-16 07:41:53 +02:00
Refactor: avoid 2x draw calls when the outliner is clamped
Campbell Barton created pull request blender/blender#129089 2024-10-16 07:41:41 +02:00
Refactor: avoid 2x draw calls when the outliner is clamped
Campbell Barton pushed to pr-128346-alt-fix at ideasman42/blender 2024-10-16 07:37:40 +02:00
38b15ea185 Refactor: avoid 2x draw calls when the outliner is clamped
2aee3331f1 Cleanup: reduce the scope of startx/y variables in outliner drawing
ee9f16227b Cleanup: pass TreeViewContext by const reference
948c9921a5 Cleanup: context arguments for outliner drawing
e6d684a357 Merge branch 'blender-v4.3-release'
Compare 10 commits »
Campbell Barton created branch pr-128346-alt-fix in ideasman42/blender 2024-10-16 07:37:40 +02:00
Campbell Barton pushed to main at blender/blender 2024-10-16 07:32:50 +02:00
2aee3331f1 Cleanup: reduce the scope of startx/y variables in outliner drawing
Campbell Barton pushed to main at blender/blender 2024-10-16 07:13:33 +02:00
ee9f16227b Cleanup: pass TreeViewContext by const reference
948c9921a5 Cleanup: context arguments for outliner drawing
Compare 2 commits »
Campbell Barton pushed to main at blender/blender 2024-10-16 06:09:02 +02:00
4bc9dc0c44 Merge branch 'blender-v4.3-release'
9bd2e3554a Merge branch 'blender-v4.3-release'
93c984283e Cleanup: quiet compiler warnings
346bea93cc Cleanup: wrap long lines
c3b067dc80 Cleanup: single/double quote use in scripts
Compare 5 commits »
Campbell Barton pushed to blender-v4.3-release at blender/blender 2024-10-16 06:01:28 +02:00
346bea93cc Cleanup: wrap long lines
Campbell Barton pushed to blender-v4.3-release at blender/blender 2024-10-16 05:54:12 +02:00
c3b067dc80 Cleanup: single/double quote use in scripts
Campbell Barton pushed to main at blender/blender 2024-10-16 05:10:11 +02:00
71198d4f8f Merge branch 'blender-v4.3-release'
7ae7592899 Fix #128346: Search results fail to display in the outliner
Compare 2 commits »
Campbell Barton closed issue blender/blender#128346 2024-10-16 05:10:09 +02:00
Regression: outliner delay refreshing makes search results fail to display